Skip to content

Commit 542429a

Browse files
fix: improve error item message for plain objects (#286)
Fixes: #252
1 parent 0a493fb commit 542429a

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

src/populate-error-message.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
import * as is from 'is';
1818
import has = require('lodash.has');
19+
import * as util from 'util';
1920

2021
import {buildStackTrace} from './build-stack-trace';
2122
import {ErrorMessage} from './classes/error-message';
@@ -109,7 +110,7 @@ function populateFromObject(ob: PopulatedObject, errorMessage: ErrorMessage) {
109110
if (has(ob, 'message')) {
110111
errorMessage.setMessage(ob.message!);
111112
} else {
112-
errorMessage.setMessage(buildStackTrace('' + ob));
113+
errorMessage.setMessage(buildStackTrace(util.inspect(ob)));
113114
}
114115

115116
if (has(ob, 'user')) {

system-test/error-reporting.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -630,7 +630,7 @@ describe('error-reporting', () => {
630630
async function(this) {
631631
this.timeout(TIMEOUT);
632632
await verifyReporting({someKey: 'someValue'}, message => {
633-
return message.startsWith('[object Object]\n');
633+
return message.startsWith('{ someKey: \'someValue\' }\n');
634634
}, 1, TIMEOUT);
635635
});
636636

test/unit/populate-error-message.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,9 @@ describe('populate-error-message', () => {
114114
it('Message Field: Should default the field given lack-of input given ' +
115115
'an object',
116116
() => {
117-
const err = {};
117+
const err = {error: 'some error message'};
118118
populateErrorMessage(err, em);
119-
assert(em.message.startsWith('[object Object]'));
119+
assert(em.message.startsWith('{ error: \'some error message\' }'));
120120
});
121121

122122
it('User Field: Should set the field given valid input given an Error',

0 commit comments

Comments
 (0)