Skip to content

Commit a22c981

Browse files
chore: run CI as non-root user (#100)
1 parent 31b7144 commit a22c981

File tree

2 files changed

+26
-6
lines changed

2 files changed

+26
-6
lines changed

.circleci/config.yml

Lines changed: 25 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ jobs:
7676
node4:
7777
docker:
7878
- image: 'node:4'
79+
user: node
7980
steps: &unit_tests_steps
8081
- checkout
8182
- run: &remove_package_lock
@@ -98,18 +99,22 @@ jobs:
9899
node6:
99100
docker:
100101
- image: 'node:6'
102+
user: node
101103
steps: *unit_tests_steps
102104
node8:
103105
docker:
104106
- image: 'node:8'
107+
user: node
105108
steps: *unit_tests_steps
106109
node9:
107110
docker:
108111
- image: 'node:9'
112+
user: node
109113
steps: *unit_tests_steps
110114
lint:
111115
docker:
112116
- image: 'node:8'
117+
user: node
113118
steps:
114119
- checkout
115120
- run: *remove_package_lock
@@ -118,19 +123,26 @@ jobs:
118123
command: |
119124
npm install
120125
npm link
126+
environment:
127+
NPM_CONFIG_PREFIX: /home/node/.npm-global
121128
- run:
122129
name: Link the module being tested to the samples.
123130
command: |
124131
cd samples/
125132
npm link @google-cloud/error-reporting
126133
npm install
127134
cd ..
135+
environment:
136+
NPM_CONFIG_PREFIX: /home/node/.npm-global
128137
- run:
129138
name: Run linting.
130139
command: npm run lint
140+
environment:
141+
NPM_CONFIG_PREFIX: /home/node/.npm-global
131142
docs:
132143
docker:
133144
- image: 'node:8'
145+
user: node
134146
steps:
135147
- checkout
136148
- run: *remove_package_lock
@@ -143,6 +155,7 @@ jobs:
143155
sample_tests:
144156
docker:
145157
- image: 'node:8'
158+
user: node
146159
steps:
147160
- checkout
148161
- run: *remove_package_lock
@@ -157,27 +170,33 @@ jobs:
157170
command: |
158171
npm install
159172
npm link
173+
environment:
174+
NPM_CONFIG_PREFIX: /home/node/.npm-global
160175
- run:
161176
name: Link the module being tested to the samples.
162177
command: |
163178
cd samples/
164179
npm link @google-cloud/error-reporting
165180
npm install
166181
cd ..
182+
environment:
183+
NPM_CONFIG_PREFIX: /home/node/.npm-global
167184
- run:
168185
name: Run sample tests.
169186
command: npm run samples-test
170187
environment:
171188
GCLOUD_PROJECT: long-door-651
172-
GOOGLE_APPLICATION_CREDENTIALS: /var/error-reporting/.circleci/key.json
189+
GOOGLE_APPLICATION_CREDENTIALS: /home/node/error-reporting/.circleci/key.json
190+
NPM_CONFIG_PREFIX: /home/node/.npm-global
173191
- run:
174192
name: Remove unencrypted key.
175193
command: rm .circleci/key.json
176194
when: always
177-
working_directory: /var/error-reporting/
195+
working_directory: /home/node/error-reporting/
178196
system_tests:
179197
docker:
180198
- image: 'node:8'
199+
user: node
181200
steps:
182201
- checkout
183202
- run: *remove_package_lock
@@ -194,16 +213,17 @@ jobs:
194213
name: Run system tests.
195214
command: npm run system-test
196215
environment:
197-
GOOGLE_APPLICATION_CREDENTIALS: /var/error-reporting/.circleci/key.json
198-
GCLOUD_TESTS_KEY: /var/error-reporting/.circleci/key.json
216+
GOOGLE_APPLICATION_CREDENTIALS: /home/node/error-reporting/.circleci/key.json
217+
GCLOUD_TESTS_KEY: /home/node/error-reporting/.circleci/key.json
199218
- run:
200219
name: Remove unencrypted key.
201220
command: rm .circleci/key.json
202221
when: always
203-
working_directory: /var/error-reporting/
222+
working_directory: /home/node/error-reporting/
204223
publish_npm:
205224
docker:
206225
- image: 'node:8'
226+
user: node
207227
steps:
208228
- checkout
209229
- run:

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
"scripts": {
3434
"docs": "node node_modules/.bin/repo-tools exec -- jsdoc -c .jsdoc.js",
3535
"generate-scaffolding": "node node_modules/.bin/repo-tools generate all && node node_modules/.bin/repo-tools generate lib_samples_readme -l samples/ --config ../.cloud-repo-tools.json",
36-
"lint": "node node_modules/.bin/repo-tools lint --cmd eslint -- build/src/ samples/ build/system-test/ build/test/",
36+
"lint": "node node_modules/.bin/repo-tools lint --cmd eslint -- src/ samples/ system-test/ test/",
3737
"prettier": "node node_modules/.bin/repo-tools exec -- prettier --write src/*.js src/*/*.js samples/*.js samples/*/*.js test/*.js test/*/*.js test/*/*/*.js system-test/*.js system-test/*/*.js",
3838
"presystem-test": "npm run compile",
3939
"system-test": "nyc --exclude=\"error-message.js\" mocha ./build/system-test/*.js",

0 commit comments

Comments
 (0)