fix: do not try and authenticate when error reporting is disabled (#676)

* fix: do not try and authenticate when error reporting is disabled

* remove extra commit

* lint

* Update test to check auth call

* fix lint

* unnock

Author: comp615

src/google-apis/auth-client.ts

@@ -110,7 +110,11 @@ export class RequestHandler extends Service {
     this._config = config;
     this._logger = logger;
 
-    if (tryAuthenticate) {
+    if (!this._config.getShouldReportErrorsToAPI()) {
+      this._logger.info(
+        'Not configured to send errors to the API; skipping Google Cloud API Authentication.'
+      );
+    } else if (tryAuthenticate) {
       this.authClient.getAccessToken().then(
         () => {},
         err => {

system-test/error-reporting.ts

@@ -383,15 +383,21 @@ describe('Expected Behavior', () => {
     env.sterilizeProcess();
   });
 
-  it('Should callback with an error with a configuration that cannot report errors', done => {
+  it('Should not call auth and should callback with an error in a configuration that cannot report errors', done => {
     env.sterilizeProcess().setKeyFilename().setProjectId();
+    const scope = nock('https://www.googleapis.com:443')
+      .post('/oauth2/v4/token')
+      .reply(400);
     process.env.NODE_ENV = 'null';
     const logger = createLogger({logLevel: 5, reportMode: 'production'});
     const client = new RequestHandler(
       new Configuration(undefined, logger),
       logger
     );
+
     client.sendError({} as ErrorMessage, (err, response) => {
+      assert.strictEqual(scope.isDone(), false);
+      nock.cleanAll();
       assert(err instanceof Error);
       assert.strictEqual(err!.message, ERROR_STRING);
       assert.strictEqual(response, null);

test/unit/google-apis/auth-client.ts

@@ -110,12 +110,25 @@ describe('RequestHandler', () => {
     );
   });
 
+  it('should not request OAuth2 token if error reporting is disabled', done => {
+    verifyReportedMessage(
+      {reportMode: 'never'},
+      null, // no access token error
+      {
+        info: 'Not configured to send errors to the API; skipping Google Cloud API Authentication.',
+      },
+      done
+    );
+  });
+
   it('should not issue a warning if disabled and can communicate with the API', done => {
     process.env.NODE_ENV = 'production';
     verifyReportedMessage(
       {reportMode: 'never'},
       null, // no access token error
-      {}, // no expected logs
+      {
+        info: 'Not configured to send errors to the API; skipping Google Cloud API Authentication.',
+      },
       done
     );
   });
@@ -125,7 +138,9 @@ describe('RequestHandler', () => {
     verifyReportedMessage(
       {reportMode: 'never'},
       null, // no access token error
-      {}, // no expected logs
+      {
+        info: 'Not configured to send errors to the API; skipping Google Cloud API Authentication.',
+      },
       done
     );
   });
@@ -166,6 +181,7 @@ describe('RequestHandler', () => {
       {reportMode: 'production'},
       null, // no access token error
       {
+        info: 'Not configured to send errors to the API; skipping Google Cloud API Authentication.',
         warn:
           'The error reporting client is configured to report ' +
           'errors if and only if the NODE_ENV environment variable is set to ' +
@@ -183,6 +199,7 @@ describe('RequestHandler', () => {
       {},
       null, // no access token error
       {
+        info: 'Not configured to send errors to the API; skipping Google Cloud API Authentication.',
         warn:
           'The error reporting client is configured to report ' +
           'errors if and only if the NODE_ENV environment variable is set to ' +