Commit b4effa1
committed
fix: resolve CI test failures and risky test warnings
Fixes three issues that were causing CI failures:
1. Remove non-existent HookManager mock from Pest.php
- HookManager class doesn't exist in codebase
- Mockery usage was causing 114 "risky" test warnings
- PHPUnit detects when Mockery manipulates error handlers
2. Disable queue metrics during tests
- Prevents service provider from attempting Redis connections in CI
- Resolves "Connection refused" errors in test environment
- Tests can now run without Redis available
3. Add defensive type checking to Redis methods
- getSortedSetByRank(), getSortedSetByScore(), getSetMembers()
- Handle non-array return values (false, Redis objects)
- Matches existing pattern used in getHash() method
- Fixes performance benchmark test failures
Results:
- Before: 13 failed, 114 risky, 124 passed
- After: 2 skipped, 125 passed (350 assertions)1 parent bd4ae8a commit b4effa1
File tree
3 files changed
+12
-13
lines changed- src/Support
- tests
3 files changed
+12
-13
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
135 | 135 | | |
136 | 136 | | |
137 | 137 | | |
138 | | - | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
139 | 141 | | |
140 | 142 | | |
141 | 143 | | |
142 | 144 | | |
143 | 145 | | |
144 | 146 | | |
145 | 147 | | |
146 | | - | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
147 | 151 | | |
148 | 152 | | |
149 | 153 | | |
| |||
181 | 185 | | |
182 | 186 | | |
183 | 187 | | |
184 | | - | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
185 | 191 | | |
186 | 192 | | |
187 | 193 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | 3 | | |
5 | 4 | | |
6 | 5 | | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
32 | 35 | | |
33 | 36 | | |
34 | 37 | | |
| |||
0 commit comments