refactor: use consistent method of registering field resolvers

Author: mattbretl

src/PgConnectionArgFilterBackwardRelationsPlugin.js

@@ -22,7 +22,7 @@ module.exports = function PgConnectionArgFilterBackwardRelationsPlugin(
       pgOmit: omit,
       pgSql: sql,
       pgIntrospectionResultsByKind: introspectionResultsByKind,
-      graphql: { GraphQLInputObjectType, GraphQLBoolean },
+      graphql: { GraphQLInputObjectType },
       connectionFilterResolve,
       connectionFilterFieldResolversByTypeNameAndFieldName,
       connectionFilterTypesByTypeName,
@@ -260,9 +260,10 @@ module.exports = function PgConnectionArgFilterBackwardRelationsPlugin(
     };
 
     for (const fieldName of Object.keys(backwardRelationSpecByFieldName)) {
-      connectionFilterFieldResolversByTypeNameAndFieldName[Self.name][
-        fieldName
-      ] = resolve;
+      connectionFilterFieldResolversByTypeNameAndFieldName[Self.name] = {
+        ...connectionFilterFieldResolversByTypeNameAndFieldName[Self.name],
+        [fieldName]: resolve,
+      };
     }
 
     return extend(fields, backwardRelationFields);
@@ -395,13 +396,11 @@ module.exports = function PgConnectionArgFilterBackwardRelationsPlugin(
       }
     };
 
-    for (const manyFieldName of Object.keys(manyFields)) {
-      if (!connectionFilterFieldResolversByTypeNameAndFieldName[Self.name]) {
-        connectionFilterFieldResolversByTypeNameAndFieldName[Self.name] = {};
-      }
-      connectionFilterFieldResolversByTypeNameAndFieldName[Self.name][
-        manyFieldName
-      ] = resolve;
+    for (const fieldName of Object.keys(manyFields)) {
+      connectionFilterFieldResolversByTypeNameAndFieldName[Self.name] = {
+        ...connectionFilterFieldResolversByTypeNameAndFieldName[Self.name],
+        [fieldName]: resolve,
+      };
     }
 
     return extend(fields, manyFields);

src/PgConnectionArgFilterColumnsPlugin.js

@@ -25,8 +25,6 @@ module.exports = function PgConnectionArgFilterColumnsPlugin(builder) {
 
     connectionFilterTypesByTypeName[Self.name] = Self;
 
-    connectionFilterFieldResolversByTypeNameAndFieldName[Self.name] = {};
-
     const attrByFieldName = introspectionResultsByKind.attribute
       .filter(attr => attr.classId === table.id)
       .filter(attr => pgColumnFilter(attr, build, context))
@@ -96,9 +94,10 @@ module.exports = function PgConnectionArgFilterColumnsPlugin(builder) {
     };
 
     for (const fieldName of Object.keys(attrByFieldName)) {
-      connectionFilterFieldResolversByTypeNameAndFieldName[Self.name][
-        fieldName
-      ] = resolve;
+      connectionFilterFieldResolversByTypeNameAndFieldName[Self.name] = {
+        ...connectionFilterFieldResolversByTypeNameAndFieldName[Self.name],
+        [fieldName]: resolve,
+      };
     }
 
     return extend(fields, attrFields);

src/PgConnectionArgFilterComputedColumnsPlugin.js

@@ -122,9 +122,10 @@ module.exports = function PgConnectionArgFilterComputedColumnsPlugin(builder) {
     };
 
     for (const fieldName of Object.keys(procByFieldName)) {
-      connectionFilterFieldResolversByTypeNameAndFieldName[Self.name][
-        fieldName
-      ] = resolve;
+      connectionFilterFieldResolversByTypeNameAndFieldName[Self.name] = {
+        ...connectionFilterFieldResolversByTypeNameAndFieldName[Self.name],
+        [fieldName]: resolve,
+      };
     }
 
     return extend(fields, procFields);

src/PgConnectionArgFilterForwardRelationsPlugin.js

@@ -164,9 +164,10 @@ module.exports = function PgConnectionArgFilterForwardRelationsPlugin(builder) {
     };
 
     for (const fieldName of Object.keys(forwardRelationSpecByFieldName)) {
-      connectionFilterFieldResolversByTypeNameAndFieldName[Self.name][
-        fieldName
-      ] = resolve;
+      connectionFilterFieldResolversByTypeNameAndFieldName[Self.name] = {
+        ...connectionFilterFieldResolversByTypeNameAndFieldName[Self.name],
+        [fieldName]: resolve,
+      };
     }
 
     return extend(fields, forwardRelationFields);

src/PgConnectionArgFilterLogicalOperatorsPlugin.js

@@ -99,9 +99,10 @@ module.exports = function PgConnectionArgFilterLogicalOperatorsPlugin(builder) {
     };
 
     for (const fieldName of Object.keys(logicResolversByFieldName)) {
-      connectionFilterFieldResolversByTypeNameAndFieldName[Self.name][
-        fieldName
-      ] = resolve;
+      connectionFilterFieldResolversByTypeNameAndFieldName[Self.name] = {
+        ...connectionFilterFieldResolversByTypeNameAndFieldName[Self.name],
+        [fieldName]: resolve,
+      };
     }
 
     return extend(fields, logicalOperatorFields);