Skip to content

Conversation

@ArneTR
Copy link
Member

@ArneTR ArneTR commented Dec 5, 2025

Greptile Overview

Greptile Summary

Added version field to the Eco CI v3 endpoint to track client version information. The change extends the existing database migration and API implementation that previously added os_name, cpu_arch, and job_id fields.

Key changes:

  • Added version field to CI_MeasurementV3 model as optional string
  • Updated database schema in structure.sql and migration file to include version column
  • Modified INSERT query to include version in the correct parameter order
  • Added test coverage with version: 'v2.2' in MEASUREMENT_MODEL_V3

Issues found:

  • Outdated documentation comments incorrectly state that v3 fields are "not stored" when they are now persisted to the database

@ArneTR
Copy link
Member Author

ArneTR commented Dec 5, 2025

@greptileai

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@ArneTR
Copy link
Member Author

ArneTR commented Dec 6, 2025

Error in test result was just from a merge artifact. Removed use_clean_db

@ArneTR ArneTR merged commit 9c6ff00 into main Dec 6, 2025
@ArneTR ArneTR deleted the eco-ci-version-tag branch December 6, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants