Declarative hidden column API

[alexkrolick]

It would be really useful to be able to pass a list of hidden column ids and have the adapter invoke the imperative .hidden setter on the rowCol models. Right now we're implementing this in our shouldComponentUpdate function for the parent component.

[yashshah12]

It can be sort of like:

<Grid ... hiddenColumns=[] />

The underlying implementation can be:

_.forEach(this.grid.data.col, (column, index) => {
  if (_.includes(hiddenColumns, column.id)) {
    this.grid.data.col.get(index).hidden = true
  } else {
    this.grid.data.col.get(index).hidden = false
  }
})

[scamden]

interesting. i like the idea but would it not imply that we'd want something similar for nearly any flag or option on columns?

@yashshah12 feel free to take a stab at a PR and i'll review.

[alexkrolick]

we'd want something similar for nearly any flag or option on columns

Well... yes 😄. Can you think of a way to generalize it?

[scamden]

hmm well, my original idea is that the column descriptors are the generalized version. the way I handle it in our code is by using reselect to create memoized selectors so the column descriptors get recreated only when an input is changed

for example:

import {createSelector} from 'reselect';

const getColDescriptors = createSelector(
(state, props) =>  props.totalColumns, 
(state, props) => props.hiddenColumns, 
(totalColumns, hiddenColumns) => 
  Array.from(
   { length: totalColumns },
   (i, idx) => ({hidden : hiddenColumns[idx]})
  )
)

this assumes hiddenColumns is a map from column index to true if hidden but obviously you can adapt to any data structure. and the input functions themselves can be extracted and can even themselves be memoized if they are calculated.

we could consider making a prop for every column feature but honestly since you're already creating the descriptors why not just have that do all the work?