Skip to content

renderURLSearchParams doesn't render BoolValue and other well-known wrapper types correctly #49

@seanami

Description

@seanami

I have a request message with google.protobuf.BoolValue name = 1 as a field. When I define a value for this field in Typescript like name: { value: false }, then I see that the request made by the generated code does not include the parameter for this field.

It appears that renderURLSearchParams strips out all primitive types with zero values, but that's not expected for BoolValue, since the whole point is to be able to differentiate between false and nil.

Is there an established way to fix issues like this within this library? I see #25 and cresta#1, but it doesn't include BoolValue or the other wrapper well-known types.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions