From 82cbabd5a35d02161c1ccb9dbeab4c7c34edda5d Mon Sep 17 00:00:00 2001 From: Steven Murray Date: Mon, 6 Jul 2026 12:14:22 +0200 Subject: [PATCH] docs: cite Yung+24/25 on colossus comparison, fix Yung24 ref Aaron Yung and Miguel Vargas noticed the hmf/Colossus Tinker08 discrepancy while preparing their papers, which led directly to the growth-factor fix. Add a note and citations crediting them on the comparison page, using the repo's existing reST citation convention (no bibliography file exists to extend). Also fixes the Yung24 fitting-function `_ref` string, which had the wrong author list and MNRAS volume/page for arXiv:2309.14408 (should be Yung, Somerville, Nguyen, Behroozi, Modi, Gardner, MNRAS 530, 4868, not the previously listed authors and MNRAS 527, 5929). --- docs/technical/colossus_comparison.rst | 11 +++++++++++ src/hmf/mass_function/fitting_functions.py | 4 ++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/docs/technical/colossus_comparison.rst b/docs/technical/colossus_comparison.rst index c23b02a..c25ae1b 100644 --- a/docs/technical/colossus_comparison.rst +++ b/docs/technical/colossus_comparison.rst @@ -16,6 +16,12 @@ correct". Instead, it records the main implementation choices that explain the observed residual differences so that users and developers understand where agreement is expected and where small systematic offsets are normal. +This investigation was itself prompted by Aaron Yung and Miguel Vargas, who +independently noticed disagreement between ``hmf`` and Colossus predictions for +the Tinker08 mass function while preparing [Yung24]_ and [Yung25]_. Their reports +are what led to the growth-factor fix linked above, and we are grateful to them +for flagging the discrepancy and giving permission to reference their work here. + Setup of the comparison ----------------------- @@ -122,3 +128,8 @@ typically of order: - ``z = 10``: :math:`\sim 2\%` to :math:`14\%`, over the range :math:`10^{11}`--:math:`10^{13}\,M_\odot/h`. + +References +---------- +.. [Yung24] Yung, L. Y. Aaron, Rachel S. Somerville, Tri Nguyen, Peter Behroozi, Chirag Modi, and Jonathan P. Gardner. 'Characterizing Ultra-High-Redshift Dark Matter Halo Demographics and Assembly Histories with the GUREFT Simulations'. Monthly Notices of the Royal Astronomical Society 530, no. 4 (2024): 4868-86. https://doi.org/10.1093/mnras/stae1188. +.. [Yung25] Yung, L. Y. Aaron, Rachel S. Somerville, and Kartheik G. Iyer. 'ΛCDM Is Still Not Broken: Empirical Constraints on the Star Formation Efficiency at z ~ 12-30'. Monthly Notices of the Royal Astronomical Society 543, no. 4 (2025): 3802-13. https://doi.org/10.1093/mnras/staf1699. diff --git a/src/hmf/mass_function/fitting_functions.py b/src/hmf/mass_function/fitting_functions.py index 59763fe..6260a8a 100644 --- a/src/hmf/mass_function/fitting_functions.py +++ b/src/hmf/mass_function/fitting_functions.py @@ -2001,8 +2001,8 @@ class Yung24(BaseFittingFunction): _eq = r"A(z)\left[(\sigma/b(z))^{-a(z)} + 1\right]\exp(-c(z)/\sigma^2)" _ref = ( - "Yung, L.Y.A., Somerville, R.S., Finkelstein, S.L., Wilkins, S.M., " - "Gardner, J.P., 2024. MNRAS 527, 5929. arXiv:2309.14408" + "Yung, L.Y.A., Somerville, R.S., Nguyen, T., Behroozi, P., Modi, C., " + "Gardner, J.P., 2024. MNRAS 530, 4868. arXiv:2309.14408" ) sim_definition = SimDetails(