Merge pull request #552 from obabec/bug-resource-tags

Fix: Update number of allowed resource tags

Author: tanmay-hc

.web-docs/components/builder/arm/README.md

@@ -312,7 +312,7 @@ Providing `temp_resource_group_name` or `location` in combination with
 
 - `azure_tags` (map[string]string) - Name/value pair tags to apply to every resource deployed i.e. Resource
   Group, VM, NIC, VNET, Public IP, KeyVault, etc. The user can define up
-  to 15 tags. Tag names cannot exceed 512 characters, and tag values
+  to 50 tags. Tag names cannot exceed 512 characters, and tag values
   cannot exceed 256 characters.
 
 - `azure_tag` ([]{name string, value string}) - Same as [`azure_tags`](#azure_tags) but defined as a singular repeatable block

builder/azure/arm/config.go

@@ -389,7 +389,7 @@ type Config struct {
 	ManagedImageZoneResilient bool `mapstructure:"managed_image_zone_resilient" required:"false"`
 	// Name/value pair tags to apply to every resource deployed i.e. Resource
 	// Group, VM, NIC, VNET, Public IP, KeyVault, etc. The user can define up
-	// to 15 tags. Tag names cannot exceed 512 characters, and tag values
+	// to 50 tags. Tag names cannot exceed 512 characters, and tag values
 	// cannot exceed 256 characters.
 	AzureTags map[string]string `mapstructure:"azure_tags" required:"false"`
 	// Same as [`azure_tags`](#azure_tags) but defined as a singular repeatable block
@@ -1128,8 +1128,8 @@ func provideDefaultValues(c *Config) {
 }
 
 func assertTagProperties(c *Config, errs *packersdk.MultiError) {
-	if len(c.AzureTags) > 15 {
-		errs = packersdk.MultiErrorAppend(errs, fmt.Errorf("a max of 15 tags are supported, but %d were provided", len(c.AzureTags)))
+	if len(c.AzureTags) > 50 {
+		errs = packersdk.MultiErrorAppend(errs, fmt.Errorf("a max of 50 tags are supported, but %d were provided", len(c.AzureTags)))
 	}
 
 	for k, v := range c.AzureTags {

builder/azure/arm/config_test.go

@@ -931,9 +931,9 @@ func TestConfigShouldAcceptTag(t *testing.T) {
 	}
 }
 
-func TestConfigShouldRejectTagsInExcessOf15AcceptTags(t *testing.T) {
+func TestConfigShouldRejectTagsInExcessOf50AcceptTags(t *testing.T) {
 	tooManyTags := map[string]string{}
-	for i := 0; i < 16; i++ {
+	for i := 0; i < 51; i++ {
 		tooManyTags[fmt.Sprintf("tag%.2d", i)] = "ignored"
 	}
 
@@ -2096,7 +2096,7 @@ func TestPlanInfoPromotionCode(t *testing.T) {
 // exceeds the max tag amount, the builder should reject the configuration.
 func TestPlanInfoTooManyTagsErrors(t *testing.T) {
 	exactMaxNumberOfTags := map[string]string{}
-	for i := 0; i < 15; i++ {
+	for i := 0; i < 50; i++ {
 		exactMaxNumberOfTags[fmt.Sprintf("tag%.2d", i)] = "ignored"
 	}
 

builder/azure/dtl/config.go

@@ -573,8 +573,8 @@ func provideDefaultValues(c *Config) error {
 }
 
 func assertTagProperties(c *Config, errs *packersdk.MultiError) {
-	if len(c.AzureTags) > 15 {
-		errs = packersdk.MultiErrorAppend(errs, fmt.Errorf("a max of 15 tags are supported, but %d were provided", len(c.AzureTags)))
+	if len(c.AzureTags) > 50 {
+		errs = packersdk.MultiErrorAppend(errs, fmt.Errorf("a max of 50 tags are supported, but %d were provided", len(c.AzureTags)))
 	}
 
 	for k, v := range c.AzureTags {

builder/azure/dtl/config_test.go

@@ -276,9 +276,9 @@ func TestConfigShouldAcceptTags(t *testing.T) {
 	}
 }
 
-func TestConfigShouldRejectTagsInExcessOf15AcceptTags(t *testing.T) {
+func TestConfigShouldRejectTagsInExcessOf50AcceptTags(t *testing.T) {
 	tooManyTags := map[string]string{}
-	for i := 0; i < 16; i++ {
+	for i := 0; i < 51; i++ {
 		tooManyTags[fmt.Sprintf("tag%.2d", i)] = "ignored"
 	}
 

docs-partials/builder/azure/arm/Config-not-required.mdx

@@ -174,7 +174,7 @@
 
 - `azure_tags` (map[string]string) - Name/value pair tags to apply to every resource deployed i.e. Resource
   Group, VM, NIC, VNET, Public IP, KeyVault, etc. The user can define up
-  to 15 tags. Tag names cannot exceed 512 characters, and tag values
+  to 50 tags. Tag names cannot exceed 512 characters, and tag values
   cannot exceed 256 characters.
 
 - `azure_tag` ([]{name string, value string}) - Same as [`azure_tags`](#azure_tags) but defined as a singular repeatable block