From 65eb68c1c970e33901310c90c427adb0adebcb3d Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Tue, 28 Mar 2023 13:45:55 +0000 Subject: [PATCH 1/3] Update Rust toolchains for `/libs` to nightly-2023-03-27 --- libs/@local/status/crate/rust-toolchain.toml | 2 +- libs/antsi/rust-toolchain.toml | 2 +- libs/deer/rust-toolchain.toml | 2 +- libs/error-stack/README.md | 2 +- libs/error-stack/macros/README.md | 2 +- libs/error-stack/rust-toolchain.toml | 2 +- libs/error-stack/src/lib.rs | 2 +- libs/sarif/rust-toolchain.toml | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/libs/@local/status/crate/rust-toolchain.toml b/libs/@local/status/crate/rust-toolchain.toml index e144356a6ff..b67a9360fee 100644 --- a/libs/@local/status/crate/rust-toolchain.toml +++ b/libs/@local/status/crate/rust-toolchain.toml @@ -1,3 +1,3 @@ [toolchain] -channel = "nightly-2023-03-21" +channel = "nightly-2023-03-27" components = ['clippy', 'rustfmt'] diff --git a/libs/antsi/rust-toolchain.toml b/libs/antsi/rust-toolchain.toml index 3549554072b..f6f1915fac6 100644 --- a/libs/antsi/rust-toolchain.toml +++ b/libs/antsi/rust-toolchain.toml @@ -1,3 +1,3 @@ [toolchain] -channel = "nightly-2023-03-20" +channel = "nightly-2023-03-27" components = ['rust-src', 'clippy', 'rustfmt'] diff --git a/libs/deer/rust-toolchain.toml b/libs/deer/rust-toolchain.toml index 1d1c5df3d14..90529223da9 100644 --- a/libs/deer/rust-toolchain.toml +++ b/libs/deer/rust-toolchain.toml @@ -1,3 +1,3 @@ [toolchain] -channel = "nightly-2023-03-20" +channel = "nightly-2023-03-27" components = ['rust-src', 'clippy', 'rustfmt', 'miri'] diff --git a/libs/error-stack/README.md b/libs/error-stack/README.md index 58e3339c28f..ae88fdd8f9a 100644 --- a/libs/error-stack/README.md +++ b/libs/error-stack/README.md @@ -8,7 +8,7 @@ [![crates.io](https://img.shields.io/crates/v/error-stack)][crates.io] [![libs.rs](https://img.shields.io/badge/libs.rs-error--stack-orange)][libs.rs] -[![rust-version](https://img.shields.io/static/v1?label=Rust&message=1.63.0/nightly-2023-03-20&color=blue)][rust-version] +[![rust-version](https://img.shields.io/static/v1?label=Rust&message=1.63.0/nightly-2023-03-27&color=blue)][rust-version] [![documentation](https://img.shields.io/docsrs/error-stack)][documentation] [![license](https://img.shields.io/crates/l/error-stack)][license] [![discord](https://img.shields.io/discord/840573247803097118)][discord] diff --git a/libs/error-stack/macros/README.md b/libs/error-stack/macros/README.md index d5e6a7bd3f5..34c3df2cd86 100644 --- a/libs/error-stack/macros/README.md +++ b/libs/error-stack/macros/README.md @@ -7,7 +7,7 @@ [![crates.io](https://img.shields.io/crates/v/error-stack-macros)][crates.io] [![libs.rs](https://img.shields.io/badge/libs.rs-error--stack--macros-orange)][libs.rs] -[![rust-version](https://img.shields.io/static/v1?label=Rust&message=1.63.0/nightly-2023-03-20&color=blue)][rust-version] +[![rust-version](https://img.shields.io/static/v1?label=Rust&message=1.63.0/nightly-2023-03-27&color=blue)][rust-version] [![documentation](https://img.shields.io/docsrs/error-stack-macros)][documentation] [![license](https://img.shields.io/crates/l/error-stack)][license] [![discord](https://img.shields.io/discord/840573247803097118)][discord] diff --git a/libs/error-stack/rust-toolchain.toml b/libs/error-stack/rust-toolchain.toml index 399d2a45c53..576a5efbcdf 100644 --- a/libs/error-stack/rust-toolchain.toml +++ b/libs/error-stack/rust-toolchain.toml @@ -1,4 +1,4 @@ [toolchain] # Please also update the badges in `README.md`s (`error-stack` and `error-stack-macros`), and `src/lib.rs` -channel = "nightly-2023-03-20" +channel = "nightly-2023-03-27" components = ['rust-src', 'miri', 'clippy', 'rustfmt'] diff --git a/libs/error-stack/src/lib.rs b/libs/error-stack/src/lib.rs index 5c748781222..7d13139b3e0 100644 --- a/libs/error-stack/src/lib.rs +++ b/libs/error-stack/src/lib.rs @@ -2,7 +2,7 @@ //! //! [![crates.io](https://img.shields.io/crates/v/error-stack)][crates.io] //! [![libs.rs](https://img.shields.io/badge/libs.rs-error--stack-orange)][libs.rs] -//! [![rust-version](https://img.shields.io/static/v1?label=Rust&message=1.63.0/nightly-2023-03-20&color=blue)][rust-version] +//! [![rust-version](https://img.shields.io/static/v1?label=Rust&message=1.63.0/nightly-2023-03-27&color=blue)][rust-version] //! [![discord](https://img.shields.io/discord/840573247803097118)][discord] //! //! [crates.io]: https://crates.io/crates/error-stack diff --git a/libs/sarif/rust-toolchain.toml b/libs/sarif/rust-toolchain.toml index a18f9857268..b67a9360fee 100644 --- a/libs/sarif/rust-toolchain.toml +++ b/libs/sarif/rust-toolchain.toml @@ -1,3 +1,3 @@ [toolchain] -channel = "nightly-2023-03-20" +channel = "nightly-2023-03-27" components = ['clippy', 'rustfmt'] From da66e3635b7c0ad8ced645824fd02497dc64014e Mon Sep 17 00:00:00 2001 From: Bilal Mahmoud Date: Tue, 28 Mar 2023 16:06:43 +0200 Subject: [PATCH 2/3] fix: false-positive for `[MaybeUninit; N]` --- libs/deer/src/impls/core/array.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libs/deer/src/impls/core/array.rs b/libs/deer/src/impls/core/array.rs index bad003c8af2..2a7fb6ca00b 100644 --- a/libs/deer/src/impls/core/array.rs +++ b/libs/deer/src/impls/core/array.rs @@ -28,9 +28,13 @@ impl<'de, T: Deserialize<'de>, const N: usize> Visitor<'de> for ArrayVisitor<'de let mut result: Result<(), ArrayAccessError> = Ok(()); + // uninit_assumed_init is fine here, as `[MaybeUninit; N]` as no inhabitants, + // the code shown here is also present in 1) the rust docs and 2) as an OK example in the + // clippy docs #[allow(unsafe_code)] + #[allow(clippy::uninit_assumed_init)] // SAFETY: this is the same as `MaybeUninit::uninit_array()`, which is still unstable - let mut array = unsafe { MaybeUninit::<[MaybeUninit; N]>::uninit().assume_init() }; + let mut array: [MaybeUninit; N] = unsafe { MaybeUninit::uninit().assume_init() }; let mut index = 0; let mut failed = false; From 1e377a1068854a018112b80ab10740120bf0e11a Mon Sep 17 00:00:00 2001 From: Bilal Mahmoud Date: Tue, 28 Mar 2023 16:56:55 +0200 Subject: [PATCH 3/3] chore: move doc comment --- libs/deer/src/impls/core/array.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libs/deer/src/impls/core/array.rs b/libs/deer/src/impls/core/array.rs index 2a7fb6ca00b..a71d3e6bda6 100644 --- a/libs/deer/src/impls/core/array.rs +++ b/libs/deer/src/impls/core/array.rs @@ -28,12 +28,12 @@ impl<'de, T: Deserialize<'de>, const N: usize> Visitor<'de> for ArrayVisitor<'de let mut result: Result<(), ArrayAccessError> = Ok(()); - // uninit_assumed_init is fine here, as `[MaybeUninit; N]` as no inhabitants, - // the code shown here is also present in 1) the rust docs and 2) as an OK example in the - // clippy docs #[allow(unsafe_code)] #[allow(clippy::uninit_assumed_init)] - // SAFETY: this is the same as `MaybeUninit::uninit_array()`, which is still unstable + // SAFETY: `uninit_assumed_init` is fine here, as `[MaybeUninit; N]` as no inhabitants, + // the code shown here is also present in 1) the rust docs and 2) as an OK example in the + // clippy docs. The code is the same as in `MaybeUninit::uninit_array()`, which is still + // unstable let mut array: [MaybeUninit; N] = unsafe { MaybeUninit::uninit().assume_init() }; let mut index = 0;