update logger tests

Author: hbmartin

src/lib/host/logger.ts

@@ -2,7 +2,14 @@ import { LogLevel, type ILogger } from '../types';
 import { createConsoleLogger } from '../utils';
 import type * as vscode from 'vscode';
 
-export const disallowedLogKeys = ['password', 'secret', 'token', 'apiKey', 'apiSecret', 'content'];
+export const disallowedLogKeys: Set<string> = new Set([
+  'password',
+  'secret',
+  'token',
+  'apikey',
+  'apisecret',
+  'content',
+]);
 
 function removePromptsFromData<T>(dictionary: T | undefined | null): T | undefined {
   if (dictionary === null || dictionary === undefined) {
@@ -19,7 +26,7 @@ function removePromptsFromData<T>(dictionary: T | undefined | null): T | undefin
   try {
     const clone = structuredClone(dictionary) as Record<string, unknown>;
     for (const [key, value] of Object.entries(clone)) {
-      if (disallowedLogKeys.includes(key.toLowerCase())) {
+      if (disallowedLogKeys.has(key.toLowerCase())) {
         // eslint-disable-next-line @typescript-eslint/no-dynamic-delete
         delete clone[key];
         continue;
@@ -110,6 +117,9 @@ export const Logger: ILogger & {
    */
   {
     setOutputChannel: (outputChannel: vscode.OutputChannel | undefined) => {
+      if (LoggerImpl.outputChannel === outputChannel) {
+        return;
+      }
       LoggerImpl.dispose();
       LoggerImpl.outputChannel = outputChannel;
     },

tests/lib/host.test.ts

@@ -10,7 +10,8 @@ describe('host module exports', () => {
 
     expect(typeof Logger).toBe('object');
     expect(typeof getLogger).toBe('function');
-    expect(Array.isArray(disallowedLogKeys)).toBe(true);
+    // Recent change: disallowedLogKeys is now a Set
+    expect(disallowedLogKeys instanceof Set).toBe(true);
   });
 
   it('should export WebviewApiProvider', async () => {
@@ -52,13 +53,13 @@ describe('host module exports', () => {
       expect(typeof logger.debug).toBe('function');
     });
 
-    it('should have disallowedLogKeys array with expected values', async () => {
+    it('should have disallowedLogKeys set with expected values', async () => {
       const { disallowedLogKeys } = await import('../../src/lib/host');
 
-      expect(disallowedLogKeys.length).toBeGreaterThan(0);
-      expect(disallowedLogKeys).toContain('password');
-      expect(disallowedLogKeys).toContain('token');
-      expect(disallowedLogKeys).toContain('secret');
+      expect(disallowedLogKeys.size).toBeGreaterThan(0);
+      expect(disallowedLogKeys.has('password')).toBe(true);
+      expect(disallowedLogKeys.has('token')).toBe(true);
+      expect(disallowedLogKeys.has('secret')).toBe(true);
     });
 
     it('should have working isViewApiRequest function', async () => {

tests/lib/host/logger.test.ts

@@ -11,6 +11,9 @@ describe('host/logger', () => {
     mockOutputChannel.appendLine.mockClear();
     mockOutputChannel.dispose.mockClear();
 
+    // Route Logger output to the mocked VS Code output channel
+    Logger.setOutputChannel(mockOutputChannel);
+
     // Mock date for consistent timestamps
     originalDateNow = Date.prototype.toISOString;
     Date.prototype.toISOString = vi.fn(() => '2024-01-01T12:00:00.000Z');
@@ -19,6 +22,8 @@ describe('host/logger', () => {
   afterEach(() => {
     Date.prototype.toISOString = originalDateNow;
     vi.clearAllMocks();
+    // Reset output channel between tests
+    Logger.setOutputChannel(undefined);
   });
 
   describe('Logger static methods', () => {
@@ -320,14 +325,10 @@ describe('host/logger', () => {
 
   describe('disallowedLogKeys', () => {
     it('should export correct disallowed keys', () => {
-      expect(disallowedLogKeys).toEqual([
-        'password',
-        'secret',
-        'token',
-        'apiKey',
-        'apiSecret',
-        'content',
-      ]);
+      // Recent change: exported as Set with lowercase API keys
+      expect(disallowedLogKeys).toEqual(
+        new Set(['password', 'secret', 'token', 'apikey', 'apisecret', 'content'])
+      );
     });
   });