Skip to content

Commit 33a37dc

Browse files
Fix the regression after SignInClient changes (#901)
In order not to cause a deadlock when the sign-in happens from another task within the task scheduler with one thread. Resolves: OLPEDGE-2032 Signed-off-by: Mykhailo Kuchma <ext-mykhailo.kuchma@here.com>
1 parent 132a778 commit 33a37dc

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

olp-cpp-sdk-authentication/src/TokenEndpoint.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,9 @@ static constexpr auto kLogTag = "TokenEndpoint";
3939
AuthenticationSettings ConvertSettings(Settings settings) {
4040
AuthenticationSettings auth_settings;
4141
auth_settings.network_proxy_settings = settings.network_proxy_settings;
42-
auth_settings.task_scheduler = settings.task_scheduler;
42+
// Ignore task scheduler. It can cause a dealock on the sign in when used from
43+
// another task within `TaskScheduler` with 1 thread.
44+
//auth_settings.task_scheduler = settings.task_scheduler;
4345
auth_settings.network_request_handler = settings.network_request_handler;
4446
auth_settings.token_endpoint_url = settings.token_endpoint_url;
4547
auth_settings.use_system_time = settings.use_system_time;

0 commit comments

Comments
 (0)