Supports option max connection lifetime (#1398)

This option configures maximum lifetime for connection in
CURL based implementation. It's important for server based
code which uptime is long to recreate connections more often
to deal with load ballancer.

Relates-To: OLPSUP-23436

Signed-off-by: Yauheni Khnykin <yauheni.khnykin@here.com>

Author: Hsilgos

olp-cpp-sdk-core/include/olp/core/http/NetworkSettings.h

@@ -119,6 +119,22 @@ class CORE_API NetworkSettings final {
       "WithTransferTimeout(std::chrono::milliseconds) instead")
   NetworkSettings& WithTransferTimeout(int timeout);
 
+  /**
+   * @brief Gets max lifetime (since creation) allowed for reusing a connection.
+   *
+   * @return The lifetime.
+   */
+  std::chrono::seconds GetMaxConnectionLifetime() const;
+
+  /**
+   * @brief Sets max lifetime (since creation) allowed for reusing a connection.
+   * Supported only for CURL implementation. If set to 0, this behavior is
+   * disabled: all connections are eligible for reuse.
+   *
+   * @return A reference to *this.
+   */
+  NetworkSettings& WithMaxConnectionLifetime(std::chrono::seconds lifetime);
+
   /**
    * @brief Sets the transfer timeout.
    *
@@ -151,6 +167,8 @@ class CORE_API NetworkSettings final {
   std::chrono::milliseconds connection_timeout_ = std::chrono::seconds(60);
   /// The transfer timeout.
   std::chrono::milliseconds transfer_timeout_ = std::chrono::seconds(30);
+  /// The max lifetime since creation allowed for reusing a connection.
+  std::chrono::seconds connection_lifetime_{0};
   /// The network proxy settings.
   NetworkProxySettings proxy_settings_;
 };

olp-cpp-sdk-core/src/http/NetworkSettings.cpp

@@ -45,6 +45,10 @@ std::chrono::milliseconds NetworkSettings::GetTransferTimeoutDuration() const {
   return transfer_timeout_;
 }
 
+std::chrono::seconds NetworkSettings::GetMaxConnectionLifetime() const {
+  return connection_lifetime_;
+}
+
 const NetworkProxySettings& NetworkSettings::GetProxySettings() const {
   return proxy_settings_;
 }
@@ -74,6 +78,12 @@ NetworkSettings& NetworkSettings::WithTransferTimeout(
   return *this;
 }
 
+NetworkSettings& NetworkSettings::WithMaxConnectionLifetime(
+    std::chrono::seconds lifetime) {
+  connection_lifetime_ = lifetime;
+  return *this;
+}
+
 NetworkSettings& NetworkSettings::WithProxySettings(
     NetworkProxySettings settings) {
   proxy_settings_ = std::move(settings);

olp-cpp-sdk-core/src/http/curl/NetworkCurl.cpp

@@ -184,7 +184,7 @@ int ConvertErrorCode(CURLcode curl_code) {
   } else if ((curl_code == CURLE_UNSUPPORTED_PROTOCOL) ||
              (curl_code == CURLE_URL_MALFORMAT)) {
     return static_cast<int>(ErrorCode::INVALID_URL_ERROR);
-#if (LIBCURL_VERSION_MAJOR >= 7) && (LIBCURL_VERSION_MINOR >= 24)
+#if CURL_AT_LEAST_VERSION(7, 24, 0)
   } else if (curl_code == CURLE_FTP_ACCEPT_FAILED) {
     return static_cast<int>(ErrorCode::AUTHORIZATION_ERROR);
 #endif
@@ -624,18 +624,26 @@ ErrorCode NetworkCurl::SendImplementation(
   }
   curl_easy_setopt(handle->handle, CURLOPT_ERRORBUFFER, handle->error_text);
 
-#if (LIBCURL_VERSION_MAJOR >= 7) && (LIBCURL_VERSION_MINOR >= 21)
+#if CURL_AT_LEAST_VERSION(7, 21, 0)
   curl_easy_setopt(handle->handle, CURLOPT_ACCEPT_ENCODING, "");
   curl_easy_setopt(handle->handle, CURLOPT_TRANSFER_ENCODING, 1L);
 #endif
 
-#if (LIBCURL_VERSION_MAJOR >= 7) && (LIBCURL_VERSION_MINOR >= 25)
+#if CURL_AT_LEAST_VERSION(7, 25, 0)
   // Enable keep-alive (since Curl 7.25.0)
   curl_easy_setopt(handle->handle, CURLOPT_TCP_KEEPALIVE, 1L);
   curl_easy_setopt(handle->handle, CURLOPT_TCP_KEEPIDLE, 120L);
   curl_easy_setopt(handle->handle, CURLOPT_TCP_KEEPINTVL, 60L);
 #endif
 
+#if CURL_AT_LEAST_VERSION(7, 80, 0)
+  curl_easy_setopt(handle->handle, CURLOPT_MAXLIFETIME_CONN,
+                   config.GetMaxConnectionLifetime().count());
+#else
+  curl_easy_setopt(handle->handle, CURLOPT_FORBID_REUSE,
+                   config.GetMaxConnectionLifetime().count() ? 1L : 0L);
+#endif
+
   {
     std::lock_guard<std::mutex> lock(event_mutex_);
     AddEvent(EventInfo::Type::SEND_EVENT, handle);

olp-cpp-sdk-core/tests/http/NetworkSettingsTest.cpp

@@ -66,6 +66,17 @@ TEST(NetworkSettingsTest, WithRetriesDeprecated) {
   EXPECT_EQ(settings.GetRetries(), 5);
 }
 
+TEST(NetworkSettingsTest, WithMaxConnectionLifetimeDefault) {
+  const auto settings = olp::http::NetworkSettings();
+  EXPECT_EQ(settings.GetMaxConnectionLifetime(), std::chrono::seconds(0));
+}
+
+TEST(NetworkSettingsTest, WithMaxConnectionLifetime) {
+  const auto settings = olp::http::NetworkSettings().WithMaxConnectionLifetime(
+      std::chrono::seconds(15));
+  EXPECT_EQ(settings.GetMaxConnectionLifetime(), std::chrono::seconds(15));
+}
+
 }  // namespace
 
 PORTING_POP_WARNINGS()