Fix various style warnings (#830)

* Fix various style warnings

Fix cpplint warnings in categories:
* readability/inheritance
* whitespace/end_of_line
* whitespace/blank_line
* whitespace/semicolon
* whitespace/operators
* build/header_guard
* build/storage_class
* whitespace/ending_newline
* whitespace/indent
* whitespace/newline
* legal/copyright

Relates-To: OLPEDGE-1909

Signed-off-by: Mykhailo Kuchma <ext-mykhailo.kuchma@here.com>

Author: mykhailo-kuchma

cmake/android/tester/app/jni/com_here_android_olp_TesterActivity.h

@@ -17,6 +17,8 @@
  * License-Filename: LICENSE
  */
 
+#pragma once
+
 /* DO NOT EDIT THIS FILE - it is machine generated */
 #include <jni.h>
 /* Header for class com_here_android_olp_TesterActivity */

cmake/ios/tester/AppDelegate.h

@@ -17,6 +17,8 @@
  * License-Filename: LICENSE
  */
 
+#pragma once
+
 #import <UIKit/UIKit.h>
 
 @interface AppDelegate : UIResponder <UIApplicationDelegate>

cmake/ios/tester/MyViewController.h

@@ -17,6 +17,8 @@
  * License-Filename: LICENSE
  */
 
+#pragma once
+
 #import <UIKit/UIKit.h>
 
 @interface MyViewController : UIViewController

examples/ios/AppDelegate.h

@@ -17,6 +17,8 @@
  * License-Filename: LICENSE
  */
 
+#pragma once
+
 #import <UIKit/UIKit.h>
 
 @interface AppDelegate : UIResponder<UIApplicationDelegate>

examples/ios/ViewController.h

@@ -17,6 +17,8 @@
  * License-Filename: LICENSE
  */
 
+#pragma once
+
 #import <UIKit/UIKit.h>
 
 @interface ViewController : UIViewController

examples/main.cpp

@@ -208,7 +208,7 @@ int RunExamples(const AccessKey& access_key, int examples_to_run,
 }
 
 int main(int argc, char** argv) {
-  AccessKey access_key{};  // You can specify your here.access.key.id 
+  AccessKey access_key{};  // You can specify your here.access.key.id
                            // and here.access.key.secret
   std::string catalog;     // the HRN of the catalog to which you to publish data
   std::string layer_id;    // the of the layer inside the catalog to which you

olp-cpp-sdk-authentication/include/olp/authentication/IntrospectAppResult.h

@@ -115,7 +115,7 @@ class AUTHENTICATION_API IntrospectAppResult {
    * @param scopes The list of strings representing the scopes.
    */
   void SetAllowedScopes(std::vector<std::string> scopes) {
-    allowed_scopes_= std::move(scopes);
+    allowed_scopes_ = std::move(scopes);
   }
 
   /**
@@ -151,7 +151,7 @@ class AUTHENTICATION_API IntrospectAppResult {
    * @param reason The token endpoint authentication reason.
    */
   void SetTokenEndpointAuthMethodReason(std::string reason) {
-    token_endpoint_auth_method_reason_= std::move(reason);
+    token_endpoint_auth_method_reason_ = std::move(reason);
   }
 
   /**
@@ -327,6 +327,7 @@ class AUTHENTICATION_API IntrospectAppResult {
    * @param hrn The application HRN.
    */
   void SetHrn(std::string hrn) { hrn_ = std::move(hrn); }
+
  private:
   std::string client_id_;
   std::string name_;

olp-cpp-sdk-authentication/src/SignInResult.cpp

@@ -57,12 +57,11 @@ time_t SignInResult::GetExpiryTime() const { return impl_->GetExpiryTime(); }
 const std::string& SignInResult::GetUserIdentifier() const {
   return impl_->GetUserIdentifier();
 }
-  
-std::chrono::seconds SignInResult::GetExpiresIn() const
-{
-    return impl_->GetExpiresIn();
+
+std::chrono::seconds SignInResult::GetExpiresIn() const {
+  return impl_->GetExpiresIn();
 }
-  
+
 const std::string& SignInResult::GetScope() const { return impl_->GetScope(); }
 
 SignInResult::SignInResult(std::shared_ptr<SignInResultImpl> impl)

olp-cpp-sdk-authentication/src/SignInResultImpl.h

@@ -93,7 +93,7 @@ class SignInResultImpl : public BaseResult {
   std::string token_type_;
   time_t expiry_time_;
   std::chrono::seconds expires_in_;
-  
+
   std::string refresh_token_;
   std::string user_identifier_;
   std::string scope_;

olp-cpp-sdk-core/include/olp/core/logging/FileAppender.h

@@ -43,7 +43,7 @@ class CORE_API FileAppender : public IAppender {
   explicit FileAppender(
       const std::string& fileName, bool append = false,
       MessageFormatter formatter = MessageFormatter::createDefault());
-  virtual ~FileAppender() override;
+  ~FileAppender() override;
 
   /**
    * @brief Returns whether or not the stream is opened and can be written to.