access_token is incorrectly called oauth_token

[fractallian]

in FaceplateSession

  if (signed_request) {
      this.token  = signed_request.oauth_token;
      this.signed_request = signed_request;
  }

should read:

  if (signed_request) {
      this.token  = signed_request.access_token;
      this.signed_request = signed_request;
  }

[hiattp]

Ummm... thats not true. It clearly says oauth_token in the fbook docs (https://developers.facebook.com/docs/authentication/canvas/). And predictably it doesn't work if you try to use it with signed_request.access_token -- did you try it? Maybe its different for non-canvas apps?

Granted, it is confusing since its called access_token pretty much everywhere else except the parsed signed request.

This also causes issues in the parse_signed_request method when you check for the token (in your version this checks for data.access_token, which will never evaluate to true, at least in canvas apps):

if (data.oauth_token) {
  cb(data);
  return;
}

[pwagener]

Anyone still looking at this? The 'parse_signed_request' method is still looking for 'access_token', when the Canvas Apps docs and the signed_request docs both clearly specify 'oauth_token'.

Is there a situation where the user's token comes into the signed request as "access_token"? Should Faceplate just check for both of them and be done with it? That's what I'm doing in my currently local fork, at least....