Updated htmldoc::save() to return the compiled code instead of true if saved, as it returns the code if no file is specified.

Updated tests.

Author: hexydec

src/htmldoc.php

@@ -666,8 +666,9 @@ public function remove(string $selector = null) : htmldoc {
 	/**
 	 * Compile the document as an HTML string and save it to the specified location
 	 *
+	 * @param string|null $file The file location to save the document to, or null to just return the compiled code
 	 * @param array $options An array indicating output options, this is merged with htmldoc::$output
-	 * @return string|bool The compiled HTML, or false on error
+	 * @return string|bool The compiled HTML, or false if the file could not be saved
 	 */
 	public function save(string $file = null, array $options = []) {
 
@@ -686,17 +687,12 @@ public function save(string $file = null, array $options = []) {
 			$html = (string) \mb_convert_encoding($html, $options['charset']);
 		}
 
-		// send back as string
-		if (!$file) {
-			return $html;
-
 		// save file
-		} elseif (\file_put_contents($file, $html) === false) {
+		if ($file && \file_put_contents($file, $html) === false) {
 			\trigger_error('File could not be written', E_USER_WARNING);
-		} else {
-			return true;
+			return false;
 		}
-		return false;
+		return $html;
 	}
 
 	/**

tests/htmldocTest.php

@@ -152,7 +152,7 @@ public function testCanSaveDocument() {
 			if (file_exists($file)) {
 				unlink($file);
 			}
-			$this->assertEquals(true, $doc->save($file), 'Can save document');
+			$this->assertEquals($doc->html(), $doc->save($file), 'Can save document');
 			$this->assertEquals(true, file_exists($file), 'Saved document ecists');
 			$this->assertEquals('<div>Hello world</div>', file_get_contents($file), 'Saved document has the correct content');
 			unlink($file);