Update to Holochain 0.6.1#1
Conversation
Bump holo_hash, holochain_zome_types to 0.6.1 and pyo3 to 0.28. - ZomeCallUnsigned renamed to ZomeCallParams; data_to_sign() replaced by serialize_and_hash() returning (bytes, hash) — return the hash. - HoloHash::from_raw_39 now panics; use fallible try_from_raw_39. - Nonce256Bits moved to holochain_nonce (added as dependency). - pyo3 0.28: Bound module API, #[pyclass(from_py_object)], explicit #[pyo3(signature)] for optional cap_secret. - flake.nix switched to holonix main-0.6. - test.py expected values regenerated: hash is now sha2_512 (64 bytes) and pyo3 returns Vec<u8> as bytes rather than a list.
Move the mislabelled [dependencies] table into [project.dependencies] so pip install . pulls maturin into the venv, making the README's subsequent maturin develop step work without a separate install.
- Add a test job that builds (pip install .) and runs test.py, gating the wheel-build jobs on it. - Pin a stable Rust toolchain for the Holochain 0.6 crate builds. - Bump deprecated actions: checkout v3->v4, setup-python v4->v5, upload/download-artifact v3->v4 (v3 was retired). - Give each build job a unique artifact name and merge them on download, as required by upload-artifact v4 (same-name uploads now collide). - Bump pinned Python 3.10 -> 3.12.
|
❌ Found 1 compliant commit and 3 non-compliant commits in d6b3828...123fc7f. Commit d6b3828 by @synchwire is not conform to the conventional commit specification :
Bump holo_hash, holochain_zome_types to 0.6.1 and pyo3 to 0.28.
Commit 7676cf6 by @synchwire is not conform to the conventional commit specification :
Move the mislabelled [dependencies] table into [project.dependencies] so
Commit 123fc7f by @synchwire is not conform to the conventional commit specification :
|
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Updates the project to crates compatible with the Holochain 0.6.1 release (from 0.2.6).
Rust / crate changes
holo_hash,holochain_zome_types0.2.6 → 0.6.1; addholochain_nonce0.6.1 (Nonce256Bitsis no longer re-exported byholochain_zome_types).pyo30.19 → 0.28.ZomeCallUnsigned→ZomeCallParams(the Python class nameZomeCallUnsignedPyis kept, so the Python API is unchanged).HoloHash::from_raw_39now panics; switched to the fallibletry_from_raw_39.data_to_sign()removed →serialize_and_hash()returns(bytes, hash); we return the hash (the value to sign).Boundmodule API,#[pyclass(from_py_object)], explicit#[pyo3(signature = …)]for the optionalcap_secret.Behaviour changes (reflected in
test.py)Vec<u8>to Pythonbytesrather than alist; assertions updated accordingly.Because the serialization format changed across the release jump, the bytes produced now differ from 0.2.x — expected, but relevant to any downstream signers.
Packaging / env
flake.nixswitched toholonix?ref=main-0.6(+ regeneratedflake.lock).maturinin[project.dependencies](was a mislabelled[dependencies]table that no tool read), so the README'spip install .thenmaturin developflow works as written.CI
testjob builds (pip install .) and runstest.py, gating the wheel-build jobs.stableRust toolchain for the Holochain 0.6 crate builds.Notes / to watch
x86,aarch64,armv7) may still fail compiling Holochain's native dependencies under manylinux. Thetestjob gives a clean native x86_64 signal; if the cross-builds break, those targets likely need trimming.