improve coverage

Author: PierreMarchand20

.github/workflows/CI.yml

@@ -137,11 +137,12 @@ jobs:
       - name: Run tests
         run: |
           export PYTHONPATH="$PWD/build"
-          mpirun -np 1 ${{ matrix.MPIEXEC_PREFLAGS }} python3 -m pytest tests --ignore=tests/test_hmatrix.py
-          mpirun -np 2 ${{ matrix.MPIEXEC_PREFLAGS }} python3 -m pytest tests --ignore=tests/test_hmatrix.py
-          mpirun -np 3 ${{ matrix.MPIEXEC_PREFLAGS }} python3 -m pytest tests --ignore=tests/test_hmatrix.py
-          mpirun -np 4 ${{ matrix.MPIEXEC_PREFLAGS }} python3 -m pytest tests --ignore=tests/test_hmatrix.py
+          mpirun -np 1 ${{ matrix.MPIEXEC_PREFLAGS }} python3 -m pytest tests --ignore=tests/test_hmatrix.py --ignore=tests/test_logger.py
+          mpirun -np 2 ${{ matrix.MPIEXEC_PREFLAGS }} python3 -m pytest tests --ignore=tests/test_hmatrix.py --ignore=tests/test_logger.py
+          mpirun -np 3 ${{ matrix.MPIEXEC_PREFLAGS }} python3 -m pytest tests --ignore=tests/test_hmatrix.py --ignore=tests/test_logger.py
+          mpirun -np 4 ${{ matrix.MPIEXEC_PREFLAGS }} python3 -m pytest tests --ignore=tests/test_hmatrix.py --ignore=tests/test_logger.py
           python3 -m pytest tests/test_hmatrix.py
+          python3 -m pytest tests/test_logger.py
 
       - name: Check format
         if: matrix.CODE_COVERAGE == 'ON'

lib/htool

@@ -45,8 +45,8 @@ class VirtualLowRankGeneratorPython : public VirtualLowRankGenerator<Coefficient
     }
 
     bool copy_low_rank_approximation(int M, int N, const int *const rows, const int *const cols, int reqrank, LowRankMatrix<CoefficientPrecision> &lrmat) const override {
-        Logger::get_instance().log(LogLevel::ERROR, "copy_low_rank_approximation with required rank is not implemented in the python interface.");
-        return false;
+        Logger::get_instance().log(LogLevel::ERROR, "copy_low_rank_approximation with required rank is not implemented in the python interface."); // LCOV_EXCL_LINE
+        return false;                                                                                                                              // LCOV_EXCL_LINE
     }
 
     // lcov does not see it because of trampoline I assume

src/htool/hmatrix/interfaces/virtual_low_rank_generator.hpp

@@ -35,10 +35,12 @@
 #include "matplotlib/cluster.hpp"
 #include "matplotlib/hmatrix.hpp"
 #include "misc/logger.hpp"
+#include "misc/testing.hpp"
 
 PYBIND11_MODULE(Htool, m) {
     // Delegate logging to python logging module
     htool::Logger::get_instance().set_current_writer(std::make_shared<PythonLoggerWriter>());
+    m.def("test_logger", &test_logger);
 
 #ifdef HAVE_MPI
     // import the mpi4py API

src/htool/main.cpp

@@ -0,0 +1,13 @@
+#ifndef HTOOL_PYTHON_MISC_TESTING_CPP
+#define HTOOL_PYTHON_MISC_TESTING_CPP
+#include <htool/misc/logger.hpp>
+
+void test_logger() {
+    htool::Logger::get_instance().log(htool::LogLevel::CRITICAL, "Critical message");
+    htool::Logger::get_instance().log(htool::LogLevel::ERROR, "Error message");
+    htool::Logger::get_instance().log(htool::LogLevel::WARNING, "Warning message");
+    htool::Logger::get_instance().log(htool::LogLevel::DEBUG, "Debug message");
+    htool::Logger::get_instance().log(htool::LogLevel::INFO, "Info message");
+}
+
+#endif

src/htool/misc/testing.hpp

@@ -0,0 +1,8 @@
+import logging
+
+import Htool
+
+
+def test_logger():
+    logging.basicConfig(level=logging.DEBUG)
+    Htool.test_logger()