fix(#8): fix flaky integration tests caused by wrong dispose order

https-richardy · https-richardy · commit 68597907e9b5 · 2026-03-05T00:37:28.000-03:00
diff --git a/Boundaries/Comanda.Payments/Tests/Fixtures/WebApplicationFixture.cs b/Boundaries/Comanda.Payments/Tests/Fixtures/WebApplicationFixture.cs
@@ -20,6 +20,7 @@ public WebApplicationFixture()
     public async ValueTask InitializeAsync()
     {
         await _databaseFixture.InitializeAsync();
+        await _databaseFixture.CleanDatabaseAsync();
 
         Environment.SetEnvironmentVariable("Settings__Database__ConnectionString", _databaseFixture.ConnectionString);
         Environment.SetEnvironmentVariable("Settings__Database__DatabaseName", _databaseFixture.DatabaseName);
@@ -65,8 +66,7 @@ public async ValueTask DisposeAsync()
     {
         HttpClient.Dispose();
 
-        await _factory.DisposeAsync();
-        await _databaseFixture.CleanDatabaseAsync();
+        await _factory.DisposeAsync()
         await _databaseFixture.DisposeAsync();
     }
 }
diff --git a/Boundaries/Comanda.Stores/Tests/Fixtures/WebApplicationFixture.cs b/Boundaries/Comanda.Stores/Tests/Fixtures/WebApplicationFixture.cs
@@ -17,6 +17,7 @@ public WebApplicationFixture()
     public async ValueTask InitializeAsync()
     {
         await _databaseFixture.InitializeAsync();
+        await _databaseFixture.CleanDatabaseAsync();
 
         Environment.SetEnvironmentVariable("Settings__Database__ConnectionString", _databaseFixture.ConnectionString);
         Environment.SetEnvironmentVariable("Settings__Database__DatabaseName", _databaseFixture.DatabaseName);
@@ -50,7 +51,6 @@ public async ValueTask DisposeAsync()
         HttpClient.Dispose();
 
         await _factory.DisposeAsync();
-        await _databaseFixture.CleanDatabaseAsync();
         await _databaseFixture.DisposeAsync();
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,7 @@ public WebApplicationFixture()`
`20`	`20`	`public async ValueTask InitializeAsync()`
`21`	`21`	`{`
`22`	`22`	`await _databaseFixture.InitializeAsync();`
	`23`	`+ await _databaseFixture.CleanDatabaseAsync();`
`23`	`24`
`24`	`25`	`Environment.SetEnvironmentVariable("Settings__Database__ConnectionString", _databaseFixture.ConnectionString);`
`25`	`26`	`Environment.SetEnvironmentVariable("Settings__Database__DatabaseName", _databaseFixture.DatabaseName);`
`@@ -65,8 +66,7 @@ public async ValueTask DisposeAsync()`
`65`	`66`	`{`
`66`	`67`	`HttpClient.Dispose();`
`67`	`68`
`68`		`- await _factory.DisposeAsync();`
`69`		`- await _databaseFixture.CleanDatabaseAsync();`
	`69`	`+ await _factory.DisposeAsync()`
`70`	`70`	`await _databaseFixture.DisposeAsync();`
`71`	`71`	`}`
`72`	`72`	`}`
Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@ public WebApplicationFixture()`
`17`	`17`	`public async ValueTask InitializeAsync()`
`18`	`18`	`{`
`19`	`19`	`await _databaseFixture.InitializeAsync();`
	`20`	`+ await _databaseFixture.CleanDatabaseAsync();`
`20`	`21`
`21`	`22`	`Environment.SetEnvironmentVariable("Settings__Database__ConnectionString", _databaseFixture.ConnectionString);`
`22`	`23`	`Environment.SetEnvironmentVariable("Settings__Database__DatabaseName", _databaseFixture.DatabaseName);`
`@@ -50,7 +51,6 @@ public async ValueTask DisposeAsync()`
`50`	`51`	`HttpClient.Dispose();`
`51`	`52`
`52`	`53`	`await _factory.DisposeAsync();`
`53`		`- await _databaseFixture.CleanDatabaseAsync();`
`54`	`54`	`await _databaseFixture.DisposeAsync();`
`55`	`55`	`}`
`56`	`56`	`}`