Skip to content

Commit c211575

Browse files
merge pull request #9 from https-richardy/fix/08-flaky-integration-tests-due-to-wrong-dispose
[#8] - flaky integration tests due to wrong dispose
2 parents e342cdc + bc9ca8d commit c211575

5 files changed

Lines changed: 5 additions & 5 deletions

File tree

Boundaries/Comanda.Orders/Tests/Fixtures/WebApplicationFixture.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ public WebApplicationFixture()
1717
public async ValueTask InitializeAsync()
1818
{
1919
await _databaseFixture.InitializeAsync();
20+
await _databaseFixture.CleanDatabaseAsync();
2021

2122
Environment.SetEnvironmentVariable("Settings__Database__ConnectionString", _databaseFixture.ConnectionString);
2223
Environment.SetEnvironmentVariable("Settings__Database__DatabaseName", _databaseFixture.DatabaseName);
@@ -63,7 +64,6 @@ public async ValueTask DisposeAsync()
6364
HttpClient.Dispose();
6465

6566
await _factory.DisposeAsync();
66-
await _databaseFixture.CleanDatabaseAsync();
6767
await _databaseFixture.DisposeAsync();
6868
}
6969
}

Boundaries/Comanda.Payments/Tests/Fixtures/WebApplicationFixture.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ public WebApplicationFixture()
2020
public async ValueTask InitializeAsync()
2121
{
2222
await _databaseFixture.InitializeAsync();
23+
await _databaseFixture.CleanDatabaseAsync();
2324

2425
Environment.SetEnvironmentVariable("Settings__Database__ConnectionString", _databaseFixture.ConnectionString);
2526
Environment.SetEnvironmentVariable("Settings__Database__DatabaseName", _databaseFixture.DatabaseName);
@@ -66,7 +67,6 @@ public async ValueTask DisposeAsync()
6667
HttpClient.Dispose();
6768

6869
await _factory.DisposeAsync();
69-
await _databaseFixture.CleanDatabaseAsync();
7070
await _databaseFixture.DisposeAsync();
7171
}
7272
}

Boundaries/Comanda.Profiles/Tests/Fixtures/WebApplicationFixture.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ public WebApplicationFixture()
2020
public async ValueTask InitializeAsync()
2121
{
2222
await _databaseFixture.InitializeAsync();
23+
await _databaseFixture.CleanDatabaseAsync();
2324

2425
Environment.SetEnvironmentVariable("Settings__Database__ConnectionString", _databaseFixture.ConnectionString);
2526
Environment.SetEnvironmentVariable("Settings__Database__DatabaseName", _databaseFixture.DatabaseName);
@@ -66,7 +67,6 @@ public async ValueTask DisposeAsync()
6667
HttpClient.Dispose();
6768

6869
await _factory.DisposeAsync();
69-
await _databaseFixture.CleanDatabaseAsync();
7070
await _databaseFixture.DisposeAsync();
7171
}
7272
}

Boundaries/Comanda.Stores/Tests/Fixtures/WebApplicationFixture.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ public WebApplicationFixture()
1717
public async ValueTask InitializeAsync()
1818
{
1919
await _databaseFixture.InitializeAsync();
20+
await _databaseFixture.CleanDatabaseAsync();
2021

2122
Environment.SetEnvironmentVariable("Settings__Database__ConnectionString", _databaseFixture.ConnectionString);
2223
Environment.SetEnvironmentVariable("Settings__Database__DatabaseName", _databaseFixture.DatabaseName);
@@ -50,7 +51,6 @@ public async ValueTask DisposeAsync()
5051
HttpClient.Dispose();
5152

5253
await _factory.DisposeAsync();
53-
await _databaseFixture.CleanDatabaseAsync();
5454
await _databaseFixture.DisposeAsync();
5555
}
5656
}

Boundaries/Comanda.Subscriptions/Tests/Fixtures/WebApplicationFixture.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ public WebApplicationFixture()
2121
public async ValueTask InitializeAsync()
2222
{
2323
await _databaseFixture.InitializeAsync();
24+
await _databaseFixture.CleanDatabaseAsync();
2425

2526
Environment.SetEnvironmentVariable("Settings__Database__ConnectionString", _databaseFixture.ConnectionString);
2627
Environment.SetEnvironmentVariable("Settings__Database__DatabaseName", _databaseFixture.DatabaseName);
@@ -73,7 +74,6 @@ public async ValueTask DisposeAsync()
7374
HttpClient.Dispose();
7475

7576
await _factory.DisposeAsync();
76-
await _databaseFixture.CleanDatabaseAsync();
7777
await _databaseFixture.DisposeAsync();
7878
}
7979
}

0 commit comments

Comments
 (0)