From a8c40c6fc48ee906fcab51cd3ea2592223bd7345 Mon Sep 17 00:00:00 2001 From: Richard Garcia Date: Thu, 5 Mar 2026 00:21:51 -0300 Subject: [PATCH 1/5] fix(#8): fix flaky integration tests caused by wrong dispose order --- .../Tests/Fixtures/WebApplicationFixture.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Boundaries/Comanda.Subscriptions/Tests/Fixtures/WebApplicationFixture.cs b/Boundaries/Comanda.Subscriptions/Tests/Fixtures/WebApplicationFixture.cs index 565f03e..647db22 100644 --- a/Boundaries/Comanda.Subscriptions/Tests/Fixtures/WebApplicationFixture.cs +++ b/Boundaries/Comanda.Subscriptions/Tests/Fixtures/WebApplicationFixture.cs @@ -21,6 +21,7 @@ public WebApplicationFixture() public async ValueTask InitializeAsync() { await _databaseFixture.InitializeAsync(); + await _databaseFixture.CleanDatabaseAsync(); Environment.SetEnvironmentVariable("Settings__Database__ConnectionString", _databaseFixture.ConnectionString); Environment.SetEnvironmentVariable("Settings__Database__DatabaseName", _databaseFixture.DatabaseName); @@ -73,7 +74,6 @@ public async ValueTask DisposeAsync() HttpClient.Dispose(); await _factory.DisposeAsync(); - await _databaseFixture.CleanDatabaseAsync(); await _databaseFixture.DisposeAsync(); } } From 19735e0d34167e71c179c8534bbd43c36543952f Mon Sep 17 00:00:00 2001 From: Richard Garcia Date: Thu, 5 Mar 2026 00:28:33 -0300 Subject: [PATCH 2/5] fix(#8): fix flaky integration tests caused by wrong dispose order --- .../Comanda.Profiles/Tests/Fixtures/WebApplicationFixture.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Boundaries/Comanda.Profiles/Tests/Fixtures/WebApplicationFixture.cs b/Boundaries/Comanda.Profiles/Tests/Fixtures/WebApplicationFixture.cs index 24cde00..c2b3894 100644 --- a/Boundaries/Comanda.Profiles/Tests/Fixtures/WebApplicationFixture.cs +++ b/Boundaries/Comanda.Profiles/Tests/Fixtures/WebApplicationFixture.cs @@ -20,6 +20,7 @@ public WebApplicationFixture() public async ValueTask InitializeAsync() { await _databaseFixture.InitializeAsync(); + await _databaseFixture.CleanDatabaseAsync(); Environment.SetEnvironmentVariable("Settings__Database__ConnectionString", _databaseFixture.ConnectionString); Environment.SetEnvironmentVariable("Settings__Database__DatabaseName", _databaseFixture.DatabaseName); @@ -66,7 +67,6 @@ public async ValueTask DisposeAsync() HttpClient.Dispose(); await _factory.DisposeAsync(); - await _databaseFixture.CleanDatabaseAsync(); await _databaseFixture.DisposeAsync(); } } From 5eebc29891552da444fec52b359bd5908d223b75 Mon Sep 17 00:00:00 2001 From: Richard Garcia Date: Thu, 5 Mar 2026 00:35:23 -0300 Subject: [PATCH 3/5] fix(#8): fix flaky integration tests caused by wrong dispose order --- .../Comanda.Orders/Tests/Fixtures/WebApplicationFixture.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Boundaries/Comanda.Orders/Tests/Fixtures/WebApplicationFixture.cs b/Boundaries/Comanda.Orders/Tests/Fixtures/WebApplicationFixture.cs index bb63eec..1a3a2f7 100644 --- a/Boundaries/Comanda.Orders/Tests/Fixtures/WebApplicationFixture.cs +++ b/Boundaries/Comanda.Orders/Tests/Fixtures/WebApplicationFixture.cs @@ -17,6 +17,7 @@ public WebApplicationFixture() public async ValueTask InitializeAsync() { await _databaseFixture.InitializeAsync(); + await _databaseFixture.CleanDatabaseAsync(); Environment.SetEnvironmentVariable("Settings__Database__ConnectionString", _databaseFixture.ConnectionString); Environment.SetEnvironmentVariable("Settings__Database__DatabaseName", _databaseFixture.DatabaseName); @@ -63,7 +64,6 @@ public async ValueTask DisposeAsync() HttpClient.Dispose(); await _factory.DisposeAsync(); - await _databaseFixture.CleanDatabaseAsync(); await _databaseFixture.DisposeAsync(); } } From 68597907e9b53e52c2776008711f9eb3c5ed7e52 Mon Sep 17 00:00:00 2001 From: Richard Garcia Date: Thu, 5 Mar 2026 00:37:28 -0300 Subject: [PATCH 4/5] fix(#8): fix flaky integration tests caused by wrong dispose order --- .../Comanda.Payments/Tests/Fixtures/WebApplicationFixture.cs | 4 ++-- .../Comanda.Stores/Tests/Fixtures/WebApplicationFixture.cs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Boundaries/Comanda.Payments/Tests/Fixtures/WebApplicationFixture.cs b/Boundaries/Comanda.Payments/Tests/Fixtures/WebApplicationFixture.cs index ccba7f1..916338c 100644 --- a/Boundaries/Comanda.Payments/Tests/Fixtures/WebApplicationFixture.cs +++ b/Boundaries/Comanda.Payments/Tests/Fixtures/WebApplicationFixture.cs @@ -20,6 +20,7 @@ public WebApplicationFixture() public async ValueTask InitializeAsync() { await _databaseFixture.InitializeAsync(); + await _databaseFixture.CleanDatabaseAsync(); Environment.SetEnvironmentVariable("Settings__Database__ConnectionString", _databaseFixture.ConnectionString); Environment.SetEnvironmentVariable("Settings__Database__DatabaseName", _databaseFixture.DatabaseName); @@ -65,8 +66,7 @@ public async ValueTask DisposeAsync() { HttpClient.Dispose(); - await _factory.DisposeAsync(); - await _databaseFixture.CleanDatabaseAsync(); + await _factory.DisposeAsync() await _databaseFixture.DisposeAsync(); } } diff --git a/Boundaries/Comanda.Stores/Tests/Fixtures/WebApplicationFixture.cs b/Boundaries/Comanda.Stores/Tests/Fixtures/WebApplicationFixture.cs index 3d3a9bf..ecff682 100644 --- a/Boundaries/Comanda.Stores/Tests/Fixtures/WebApplicationFixture.cs +++ b/Boundaries/Comanda.Stores/Tests/Fixtures/WebApplicationFixture.cs @@ -17,6 +17,7 @@ public WebApplicationFixture() public async ValueTask InitializeAsync() { await _databaseFixture.InitializeAsync(); + await _databaseFixture.CleanDatabaseAsync(); Environment.SetEnvironmentVariable("Settings__Database__ConnectionString", _databaseFixture.ConnectionString); Environment.SetEnvironmentVariable("Settings__Database__DatabaseName", _databaseFixture.DatabaseName); @@ -50,7 +51,6 @@ public async ValueTask DisposeAsync() HttpClient.Dispose(); await _factory.DisposeAsync(); - await _databaseFixture.CleanDatabaseAsync(); await _databaseFixture.DisposeAsync(); } } From bc9ca8d9118bceca65f3347df752f0375cd7b02c Mon Sep 17 00:00:00 2001 From: Richard Garcia Date: Thu, 5 Mar 2026 00:42:51 -0300 Subject: [PATCH 5/5] fix(CS1002): this commit introduces missing comma #CS1002 ";" expected --- .../Comanda.Payments/Tests/Fixtures/WebApplicationFixture.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Boundaries/Comanda.Payments/Tests/Fixtures/WebApplicationFixture.cs b/Boundaries/Comanda.Payments/Tests/Fixtures/WebApplicationFixture.cs index 916338c..b3b4bfc 100644 --- a/Boundaries/Comanda.Payments/Tests/Fixtures/WebApplicationFixture.cs +++ b/Boundaries/Comanda.Payments/Tests/Fixtures/WebApplicationFixture.cs @@ -66,7 +66,7 @@ public async ValueTask DisposeAsync() { HttpClient.Dispose(); - await _factory.DisposeAsync() + await _factory.DisposeAsync(); await _databaseFixture.DisposeAsync(); } }