From f238e4c2ca4ab2a2c4bfe6099428a461b632c013 Mon Sep 17 00:00:00 2001 From: sayakpaul Date: Sat, 28 Feb 2026 10:53:02 +0530 Subject: [PATCH] run make style and fix Makefile. --- kernels/Makefile | 2 +- kernels/src/kernels/__init__.py | 6 ++--- kernels/src/kernels/cli/__init__.py | 22 +++++++++---------- kernels/src/kernels/cli/benchmark.py | 4 ++-- kernels/src/kernels/cli/benchmark_graphics.py | 10 ++++----- kernels/src/kernels/cli/doc.py | 3 ++- kernels/src/kernels/cli/init.py | 2 +- kernels/src/kernels/cli/skills.py | 1 - kernels/src/kernels/cli/versions.py | 3 ++- kernels/src/kernels/kernel_card_utils.py | 5 +++-- kernels/src/kernels/layer/kernelize.py | 5 ++--- kernels/src/kernels/layer/repos.py | 9 ++++---- kernels/tests/test_basic.py | 2 +- kernels/tests/test_init.py | 6 ++--- kernels/tests/test_kernel_card.py | 2 +- kernels/tests/test_layer.py | 2 +- 16 files changed, 40 insertions(+), 44 deletions(-) diff --git a/kernels/Makefile b/kernels/Makefile index 4b95e4a0..580f53ab 100644 --- a/kernels/Makefile +++ b/kernels/Makefile @@ -1,6 +1,6 @@ .PHONY: style -export check_dirs := src examples tests +export check_dirs := src tests all: src/kernels/python_depends.json diff --git a/kernels/src/kernels/__init__.py b/kernels/src/kernels/__init__.py index c5fbb243..248f712f 100644 --- a/kernels/src/kernels/__init__.py +++ b/kernels/src/kernels/__init__.py @@ -2,6 +2,8 @@ __version__ = importlib.metadata.version("kernels") +from kernels._windows import _add_additional_dll_paths +from kernels.benchmark import Benchmark from kernels.layer import ( CUDAProperties, Device, @@ -27,10 +29,6 @@ install_kernel, load_kernel, ) -from kernels.benchmark import Benchmark - - -from kernels._windows import _add_additional_dll_paths _add_additional_dll_paths() diff --git a/kernels/src/kernels/cli/__init__.py b/kernels/src/kernels/cli/__init__.py index f1726787..1a2c2768 100644 --- a/kernels/src/kernels/cli/__init__.py +++ b/kernels/src/kernels/cli/__init__.py @@ -4,26 +4,26 @@ import sys from pathlib import Path -from kernels.compat import tomllib -from kernels.lockfile import KernelLock, get_kernel_locks -from kernels.cli.upload import upload_kernels_dir -from kernels.utils import ( - install_kernel, - install_kernel_all_variants, - KNOWN_BACKENDS, -) -from kernels.cli.init import run_init, parse_kernel_name +from kernels.cli.doc import generate_readme_for_kernel +from kernels.cli.init import parse_kernel_name, run_init from kernels.cli.skills import add_skill +from kernels.cli.upload import upload_kernels_dir from kernels.cli.versions import print_kernel_versions -from kernels.cli.doc import generate_readme_for_kernel +from kernels.compat import tomllib from kernels.kernel_card_utils import ( _load_or_create_kernel_card, _update_benchmark, _update_kernel_card_available_funcs, - _update_kernel_card_license, _update_kernel_card_backends, + _update_kernel_card_license, _update_kernel_card_usage, ) +from kernels.lockfile import KernelLock, get_kernel_locks +from kernels.utils import ( + KNOWN_BACKENDS, + install_kernel, + install_kernel_all_variants, +) def main(): diff --git a/kernels/src/kernels/cli/benchmark.py b/kernels/src/kernels/cli/benchmark.py index 75695114..d764e763 100644 --- a/kernels/src/kernels/cli/benchmark.py +++ b/kernels/src/kernels/cli/benchmark.py @@ -20,7 +20,7 @@ ) from kernels.benchmark import Benchmark -from kernels.utils import _get_hf_api, _backend +from kernels.utils import _backend, _get_hf_api MISSING_DEPS: list[str] = [] @@ -457,7 +457,7 @@ def run_benchmark_class( raise RuntimeError(f"No benchmark_* methods found in {benchmark_cls.__name__}") # Load kernel once for all workloads - from kernels import get_local_kernel, get_kernel + from kernels import get_kernel, get_local_kernel if is_local: kernel = get_local_kernel(Path(repo_id), "activation") diff --git a/kernels/src/kernels/cli/benchmark_graphics.py b/kernels/src/kernels/cli/benchmark_graphics.py index 251ad923..f031a232 100644 --- a/kernels/src/kernels/cli/benchmark_graphics.py +++ b/kernels/src/kernels/cli/benchmark_graphics.py @@ -53,12 +53,9 @@ def _embed_logo_in_svg(svg_path: str, logo_size: int = 24) -> None: viewbox_match = re.search(r'viewBox="([^"]+)"', content) if viewbox_match: parts = viewbox_match.group(1).split() - width = float(parts[2]) height = float(parts[3]) else: - width_match = re.search(r'width="([0-9.]+)', content) height_match = re.search(r'height="([0-9.]+)', content) - width = float(width_match.group(1)) if width_match else 800 height = float(height_match.group(1)) if height_match else 400 svg_match = re.search(r"]*>(.*)", logo_svg, re.DOTALL) @@ -481,9 +478,10 @@ def _save_speedup_gif( ) return - from matplotlib.patches import FancyBboxPatch, Ellipse from urllib.request import urlopen + from matplotlib.patches import Ellipse, FancyBboxPatch + matplotlib.use("Agg") plt.rcParams["font.family"] = _HF_FONT @@ -753,10 +751,10 @@ def _save_speedup_svg( f'{speedup:.2f}x', f'', f' ', - f"", + "", f'', f' ', - f"", + "", ] ) diff --git a/kernels/src/kernels/cli/doc.py b/kernels/src/kernels/cli/doc.py index 4e88f20a..d48c0986 100644 --- a/kernels/src/kernels/cli/doc.py +++ b/kernels/src/kernels/cli/doc.py @@ -5,9 +5,10 @@ import yaml -from ._vendored.convert_rst_to_mdx import convert_rst_docstring_to_mdx from kernels.utils import get_kernel +from ._vendored.convert_rst_to_mdx import convert_rst_docstring_to_mdx + _RE_PARAMETERS = re.compile( r"(((?!).)*)", re.DOTALL ) diff --git a/kernels/src/kernels/cli/init.py b/kernels/src/kernels/cli/init.py index 867a8b99..f3d681e3 100644 --- a/kernels/src/kernels/cli/init.py +++ b/kernels/src/kernels/cli/init.py @@ -8,10 +8,10 @@ from pathlib import Path from typing import NamedTuple +import tomlkit from huggingface_hub import snapshot_download from huggingface_hub.utils import disable_progress_bars -import tomlkit from kernels.utils import KNOWN_BACKENDS KERNEL_NAME_PATTERN = re.compile(r"^[a-z][-a-z0-9]*[a-z0-9]$") diff --git a/kernels/src/kernels/cli/skills.py b/kernels/src/kernels/cli/skills.py index 5d4e2499..3e935a48 100644 --- a/kernels/src/kernels/cli/skills.py +++ b/kernels/src/kernels/cli/skills.py @@ -5,7 +5,6 @@ from huggingface_hub.utils import get_session - DEFAULT_SKILL_ID = "cuda-kernels" _GITHUB_RAW_BASE = ( "https://raw.githubusercontent.com/huggingface/kernels/main/" "skills/cuda-kernels" diff --git a/kernels/src/kernels/cli/versions.py b/kernels/src/kernels/cli/versions.py index aa5e1442..a752d789 100644 --- a/kernels/src/kernels/cli/versions.py +++ b/kernels/src/kernels/cli/versions.py @@ -1,9 +1,10 @@ from importlib.util import find_spec from pathlib import Path + from huggingface_hub import HfApi from kernels._versions import _get_available_versions -from kernels.utils import _get_hf_api, _build_variants +from kernels.utils import _build_variants, _get_hf_api from kernels.variants import BUILD_VARIANT_REGEX diff --git a/kernels/src/kernels/kernel_card_utils.py b/kernels/src/kernels/kernel_card_utils.py index b36973e5..cf8c3131 100644 --- a/kernels/src/kernels/kernel_card_utils.py +++ b/kernels/src/kernels/kernel_card_utils.py @@ -1,12 +1,13 @@ import ast import re from pathlib import Path - -from .compat import tomllib from typing import Any + from huggingface_hub import ModelCard, ModelCardData from huggingface_hub.errors import EntryNotFoundError, RepositoryNotFoundError +from .compat import tomllib + KERNEL_CARD_TEMPLATE_PATH = Path(__file__).parent / "card_template.md" DESCRIPTION = """ This is the repository card of {repo_id} that has been pushed on the Hub. It was built to be used with the [`kernels` library](https://github.com/huggingface/kernels). This card was automatically generated. diff --git a/kernels/src/kernels/layer/kernelize.py b/kernels/src/kernels/layer/kernelize.py index 9b318427..a6c0cd68 100644 --- a/kernels/src/kernels/layer/kernelize.py +++ b/kernels/src/kernels/layer/kernelize.py @@ -3,12 +3,11 @@ from copy import deepcopy from typing import TYPE_CHECKING -from .repos import DeviceRepos +from .device import Device from .globals import _KERNEL_MAPPING from .layer import kernelize_layer -from .repos import RepositoryProtocol from .mode import Mode -from .device import Device +from .repos import DeviceRepos, RepositoryProtocol if TYPE_CHECKING: import torch diff --git a/kernels/src/kernels/layer/repos.py b/kernels/src/kernels/layer/repos.py index 6eee11b3..e9f70caa 100644 --- a/kernels/src/kernels/layer/repos.py +++ b/kernels/src/kernels/layer/repos.py @@ -1,12 +1,11 @@ -from abc import ABC, abstractmethod -from typing import TYPE_CHECKING, Protocol, Type import sys +from abc import ABC, abstractmethod from functools import lru_cache +from typing import TYPE_CHECKING, Protocol, Type -from .device import Device -from .mode import Mode from ._interval_tree import IntervalTree -from .device import CUDAProperties, ROCMProperties +from .device import CUDAProperties, Device, ROCMProperties +from .mode import Mode if TYPE_CHECKING: from torch import nn diff --git a/kernels/tests/test_basic.py b/kernels/tests/test_basic.py index 241c9b2a..07af9a1f 100644 --- a/kernels/tests/test_basic.py +++ b/kernels/tests/test_basic.py @@ -1,7 +1,7 @@ -from huggingface_hub.errors import RepositoryNotFoundError import pytest import torch import torch.nn.functional as F +from huggingface_hub.errors import RepositoryNotFoundError from kernels import get_kernel, get_local_kernel, has_kernel, install_kernel diff --git a/kernels/tests/test_init.py b/kernels/tests/test_init.py index 5765b607..02c848dd 100644 --- a/kernels/tests/test_init.py +++ b/kernels/tests/test_init.py @@ -1,9 +1,9 @@ -import tempfile -from pathlib import Path import argparse import os +import tempfile +from pathlib import Path -from kernels.cli.init import run_init, parse_kernel_name +from kernels.cli.init import parse_kernel_name, run_init from kernels.utils import KNOWN_BACKENDS diff --git a/kernels/tests/test_kernel_card.py b/kernels/tests/test_kernel_card.py index d8bf5e38..94777333 100644 --- a/kernels/tests/test_kernel_card.py +++ b/kernels/tests/test_kernel_card.py @@ -1,6 +1,6 @@ import tempfile -from pathlib import Path from dataclasses import dataclass +from pathlib import Path from unittest.mock import patch import pytest diff --git a/kernels/tests/test_layer.py b/kernels/tests/test_layer.py index 05a586b0..34f4c979 100644 --- a/kernels/tests/test_layer.py +++ b/kernels/tests/test_layer.py @@ -1,10 +1,10 @@ import sys from contextlib import nullcontext -from huggingface_hub.errors import RepositoryNotFoundError import pytest import torch import torch.nn as nn +from huggingface_hub.errors import RepositoryNotFoundError from torch.nn import functional as F from kernels import (