Description
The POST /bot-orchestration/deploy-v2-script endpoint and V2ScriptDeployment model were accidentally removed during the refactoring in commit a299744 ("update deploy to new hummingbot version").
What was removed
Endpoint (from routers/bot_orchestration.py)
@router.post("/deploy-v2-script")
async def deploy_v2_script(
config: V2ScriptDeployment,
docker_manager: DockerService = Depends(get_docker_service),
db_manager: AsyncDatabaseManager = Depends(get_database_manager)
):
"""Creates and autostart a v2 script with a configuration if present."""
...
Model (from models/bot_orchestration.py)
class V2ScriptDeployment(BaseModel):
"""Configuration for deploying a bot with a script"""
instance_name: str
credentials_profile: str
image: str = Field(default="hummingbot/hummingbot:latest")
script: Optional[str] = None
script_config: Optional[str] = None
headless: bool = False
Impact
Users cannot deploy a simple script with a custom Docker image. Currently only deploy-v2-controllers is available, which requires controller configuration.
Expected behavior
Both endpoints should be available:
POST /bot-orchestration/deploy-v2-script - Deploy any script with custom image
POST /bot-orchestration/deploy-v2-controllers - Deploy controller-based strategies
Branch affected
feat/lp-executor (PR #120)
Steps to reproduce
- Check out
feat/lp-executor branch
- Look for
deploy-v2-script endpoint - it's missing
- Compare with
main branch where the endpoint exists
Description
The
POST /bot-orchestration/deploy-v2-scriptendpoint andV2ScriptDeploymentmodel were accidentally removed during the refactoring in commita299744("update deploy to new hummingbot version").What was removed
Endpoint (from
routers/bot_orchestration.py)Model (from
models/bot_orchestration.py)Impact
Users cannot deploy a simple script with a custom Docker image. Currently only
deploy-v2-controllersis available, which requires controller configuration.Expected behavior
Both endpoints should be available:
POST /bot-orchestration/deploy-v2-script- Deploy any script with custom imagePOST /bot-orchestration/deploy-v2-controllers- Deploy controller-based strategiesBranch affected
feat/lp-executor(PR #120)Steps to reproduce
feat/lp-executorbranchdeploy-v2-scriptendpoint - it's missingmainbranch where the endpoint exists