Skip to content

Commit 07ad42e

Browse files
Add session recording key-display usage guard
Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>
1 parent af62be9 commit 07ad42e

File tree

3 files changed

+17
-0
lines changed

3 files changed

+17
-0
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,7 @@ This runs lint, format checks, compile checks, tests, and package build.
214214
- `tests/test_session_operation_metadata_usage.py` (session manager operation-metadata usage enforcement),
215215
- `tests/test_session_parse_usage_boundary.py` (centralized session parse-helper usage boundary enforcement),
216216
- `tests/test_session_profile_update_helper_usage.py` (session profile-update parameter helper usage enforcement),
217+
- `tests/test_session_recording_key_display_helper_usage.py` (session recording key-display helper usage enforcement),
217218
- `tests/test_session_recordings_follow_redirects_boundary.py` (session recordings wrapper follow-redirect enforcement boundary),
218219
- `tests/test_session_request_function_parse_boundary.py` (session-request function-level parse boundary enforcement between parsed wrappers and resource helpers),
219220
- `tests/test_session_request_helper_usage.py` (session manager request-helper usage enforcement),

tests/test_architecture_marker_usage.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,7 @@
147147
"tests/test_session_operation_metadata_usage.py",
148148
"tests/test_session_parse_usage_boundary.py",
149149
"tests/test_session_profile_update_helper_usage.py",
150+
"tests/test_session_recording_key_display_helper_usage.py",
150151
"tests/test_session_recordings_follow_redirects_boundary.py",
151152
"tests/test_session_request_function_parse_boundary.py",
152153
"tests/test_session_request_helper_usage.py",
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
from pathlib import Path
2+
3+
import pytest
4+
5+
pytestmark = pytest.mark.architecture
6+
7+
SESSION_UTILS_MODULE = Path("hyperbrowser/client/managers/session_utils.py")
8+
9+
10+
def test_session_utils_uses_format_string_key_for_error():
11+
module_text = SESSION_UTILS_MODULE.read_text(encoding="utf-8")
12+
13+
assert "format_string_key_for_error(" in module_text
14+
assert "_MAX_KEY_DISPLAY_LENGTH" in module_text
15+
assert "_format_recording_key_display(" in module_text

0 commit comments

Comments
 (0)