Require hostname presence in base URL validation

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/config.py

@@ -61,6 +61,10 @@ def normalize_base_url(base_url: str) -> str:
             raise HyperbrowserError(
                 "base_url must start with 'https://' or 'http://' and include a host"
             )
+        if parsed_base_url.hostname is None:
+            raise HyperbrowserError(
+                "base_url must start with 'https://' or 'http://' and include a host"
+            )
         if parsed_base_url.query or parsed_base_url.fragment:
             raise HyperbrowserError(
                 "base_url must not include query parameters or fragments"

tests/test_config.py

@@ -210,6 +210,8 @@ def test_client_config_rejects_empty_or_invalid_base_url():
 
     with pytest.raises(HyperbrowserError, match="include a host"):
         ClientConfig(api_key="test-key", base_url="http://")
+    with pytest.raises(HyperbrowserError, match="include a host"):
+        ClientConfig(api_key="test-key", base_url="https://:443")
     with pytest.raises(
         HyperbrowserError, match="base_url must contain a valid port number"
     ):
@@ -373,6 +375,8 @@ def test_client_config_normalize_base_url_validates_and_normalizes():
 
     with pytest.raises(HyperbrowserError, match="base_url must start with"):
         ClientConfig.normalize_base_url("example.local")
+    with pytest.raises(HyperbrowserError, match="include a host"):
+        ClientConfig.normalize_base_url("https://:443")
     with pytest.raises(
         HyperbrowserError, match="base_url must contain a valid port number"
     ):

tests/test_url_building.py

@@ -103,6 +103,10 @@ def test_client_build_url_rejects_runtime_invalid_base_url_changes():
         with pytest.raises(HyperbrowserError, match="include a host"):
             client._build_url("/session")
 
+        client.config.base_url = "https://:443"
+        with pytest.raises(HyperbrowserError, match="include a host"):
+            client._build_url("/session")
+
         client.config.base_url = "https://example.local?foo=bar"
         with pytest.raises(
             HyperbrowserError, match="must not include query parameters"