Skip to content

Commit 2653081

Browse files
Normalize blank fallback context in request failure messages
Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>
1 parent 83f7cc7 commit 2653081

File tree

2 files changed

+15
-0
lines changed

2 files changed

+15
-0
lines changed

hyperbrowser/transport/error_utils.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,5 +77,10 @@ def format_request_failure_message(
7777
effective_method = (
7878
request_method if request_method != "UNKNOWN" else fallback_method
7979
)
80+
if not isinstance(effective_method, str) or not effective_method.strip():
81+
effective_method = "UNKNOWN"
82+
8083
effective_url = request_url if request_url != "unknown URL" else fallback_url
84+
if not isinstance(effective_url, str) or not effective_url.strip():
85+
effective_url = "unknown URL"
8186
return f"Request {effective_method} {effective_url} failed"

tests/test_transport_error_utils.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,3 +92,13 @@ def test_format_request_failure_message_prefers_request_context():
9292
)
9393

9494
assert message == "Request POST https://example.com/actual failed"
95+
96+
97+
def test_format_request_failure_message_normalizes_blank_fallback_values():
98+
message = format_request_failure_message(
99+
httpx.RequestError("network down"),
100+
fallback_method=" ",
101+
fallback_url="",
102+
)
103+
104+
assert message == "Request UNKNOWN unknown URL failed"

0 commit comments

Comments
 (0)