Adopt shared plain-string helper across parsing utilities

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/extension_utils.py

@@ -4,6 +4,7 @@
 from hyperbrowser.display_utils import format_string_key_for_error
 from hyperbrowser.exceptions import HyperbrowserError
 from hyperbrowser.models.extension import ExtensionResponse
+from hyperbrowser.type_utils import is_plain_string
 from .list_parsing_utils import parse_mapping_list_items
 
 _MAX_DISPLAYED_MISSING_KEYS = 20
@@ -17,7 +18,7 @@ def _get_type_name(value: Any) -> str:
 def _safe_stringify_key(value: object) -> str:
     try:
         normalized_key = str(value)
-        if type(normalized_key) is not str:
+        if not is_plain_string(normalized_key):
             raise TypeError("normalized key must be a string")
         return normalized_key
     except Exception:
@@ -27,7 +28,7 @@ def _safe_stringify_key(value: object) -> str:
 def _format_key_display(value: object) -> str:
     try:
         normalized_key = _safe_stringify_key(value)
-        if type(normalized_key) is not str:
+        if not is_plain_string(normalized_key):
             raise TypeError("normalized key display must be a string")
     except Exception:
         return "<unreadable key>"

hyperbrowser/client/managers/list_parsing_utils.py

@@ -2,6 +2,7 @@
 
 from hyperbrowser.exceptions import HyperbrowserError
 from hyperbrowser.mapping_utils import read_string_key_mapping
+from hyperbrowser.type_utils import is_plain_string
 
 T = TypeVar("T")
 
@@ -13,7 +14,7 @@ def _safe_key_display_for_error(
 ) -> str:
     try:
         key_text = key_display(key)
-        if type(key_text) is not str:
+        if not is_plain_string(key_text):
             raise TypeError("key display must be a string")
         return key_text
     except Exception:

hyperbrowser/client/managers/response_utils.py

@@ -6,6 +6,7 @@
 )
 from hyperbrowser.exceptions import HyperbrowserError
 from hyperbrowser.mapping_utils import read_string_key_mapping
+from hyperbrowser.type_utils import is_plain_string
 
 T = TypeVar("T")
 _MAX_OPERATION_NAME_DISPLAY_LENGTH = 120
@@ -32,11 +33,11 @@ def parse_response_model(
     model: Type[T],
     operation_name: str,
 ) -> T:
-    if type(operation_name) is not str:
+    if not is_plain_string(operation_name):
         raise HyperbrowserError("operation_name must be a non-empty string")
     try:
         normalized_operation_name_input = operation_name.strip()
-        if type(normalized_operation_name_input) is not str:
+        if not is_plain_string(normalized_operation_name_input):
             raise TypeError("normalized operation_name must be a string")
         is_empty_operation_name = len(normalized_operation_name_input) == 0
     except HyperbrowserError:

hyperbrowser/display_utils.py

@@ -1,3 +1,5 @@
+from hyperbrowser.type_utils import is_plain_string
+
 _TRUNCATED_DISPLAY_SUFFIX = "... (truncated)"
 
 
@@ -7,7 +9,7 @@ def normalize_display_text(value: str, *, max_length: int) -> str:
             "?" if ord(character) < 32 or ord(character) == 127 else character
             for character in value
         ).strip()
-        if type(sanitized_value) is not str:
+        if not is_plain_string(sanitized_value):
             return ""
         if not sanitized_value:
             return ""

hyperbrowser/exceptions.py

@@ -1,6 +1,8 @@
 # exceptions.py
 from typing import Optional, Any
 
+from hyperbrowser.type_utils import is_plain_string
+
 _MAX_EXCEPTION_DISPLAY_LENGTH = 2000
 _TRUNCATED_EXCEPTION_DISPLAY_SUFFIX = "... (truncated)"
 
@@ -21,14 +23,14 @@ def _safe_exception_text(value: Any, *, fallback: str) -> str:
         text_value = str(value)
     except Exception:
         return fallback
-    if type(text_value) is not str:
+    if not is_plain_string(text_value):
         return fallback
     try:
         sanitized_value = "".join(
             "?" if ord(character) < 32 or ord(character) == 127 else character
             for character in text_value
         )
-        if type(sanitized_value) is not str:
+        if not is_plain_string(sanitized_value):
             return fallback
         if sanitized_value.strip():
             return _truncate_exception_text(sanitized_value)

hyperbrowser/mapping_utils.py

@@ -2,6 +2,7 @@
 from typing import Any, Callable, Dict, List
 
 from hyperbrowser.exceptions import HyperbrowserError
+from hyperbrowser.type_utils import is_plain_string
 
 
 def read_string_mapping_keys(
@@ -24,7 +25,7 @@ def read_string_mapping_keys(
         ) from exc
     normalized_keys: List[str] = []
     for key in mapping_keys:
-        if type(key) is str:
+        if is_plain_string(key):
             normalized_keys.append(key)
             continue
         raise HyperbrowserError(non_string_key_error_builder(key))
@@ -55,7 +56,7 @@ def read_string_key_mapping(
         except Exception as exc:
             try:
                 key_text = key_display(key)
-                if type(key_text) is not str:
+                if not is_plain_string(key_text):
                     raise TypeError("mapping key display must be a string")
             except Exception:
                 key_text = "<unreadable key>"
@@ -75,7 +76,7 @@ def copy_mapping_values_by_string_keys(
 ) -> Dict[str, object]:
     normalized_mapping: Dict[str, object] = {}
     for key in keys:
-        if type(key) is not str:
+        if not is_plain_string(key):
             raise HyperbrowserError("mapping key list must contain plain strings")
         try:
             normalized_mapping[key] = mapping_value[key]
@@ -84,7 +85,7 @@ def copy_mapping_values_by_string_keys(
         except Exception as exc:
             try:
                 key_text = key_display(key)
-                if type(key_text) is not str:
+                if not is_plain_string(key_text):
                     raise TypeError("mapping key display must be a string")
             except Exception:
                 key_text = "<unreadable key>"