Avoid wait-helper fetch name overlength validation failures

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/polling.py

@@ -17,6 +17,7 @@
 
 T = TypeVar("T")
 _MAX_OPERATION_NAME_LENGTH = 200
+_FETCH_OPERATION_NAME_PREFIX = "Fetching "
 _CLIENT_ERROR_STATUS_MIN = 400
 _CLIENT_ERROR_STATUS_MAX = 500
 _RETRYABLE_CLIENT_ERROR_STATUS_CODES = {408, 429}
@@ -65,6 +66,13 @@ def _validate_operation_name(operation_name: str) -> None:
         raise HyperbrowserError("operation_name must not contain control characters")
 
 
+def _build_fetch_operation_name(operation_name: str) -> str:
+    prefixed_operation_name = f"{_FETCH_OPERATION_NAME_PREFIX}{operation_name}"
+    if len(prefixed_operation_name) <= _MAX_OPERATION_NAME_LENGTH:
+        return prefixed_operation_name
+    return operation_name
+
+
 def _ensure_boolean_terminal_result(result: object, *, operation_name: str) -> bool:
     _ensure_non_awaitable(
         result, callback_name="is_terminal_status", operation_name=operation_name
@@ -792,8 +800,9 @@ def wait_for_job_result(
         max_wait_seconds=max_wait_seconds,
         max_status_failures=max_status_failures,
     )
+    fetch_operation_name = _build_fetch_operation_name(operation_name)
     return retry_operation(
-        operation_name=f"Fetching {operation_name}",
+        operation_name=fetch_operation_name,
         operation=fetch_result,
         max_attempts=fetch_max_attempts,
         retry_delay_seconds=fetch_retry_delay_seconds,
@@ -828,8 +837,9 @@ async def wait_for_job_result_async(
         max_wait_seconds=max_wait_seconds,
         max_status_failures=max_status_failures,
     )
+    fetch_operation_name = _build_fetch_operation_name(operation_name)
     return await retry_operation_async(
-        operation_name=f"Fetching {operation_name}",
+        operation_name=fetch_operation_name,
         operation=fetch_result,
         max_attempts=fetch_max_attempts,
         retry_delay_seconds=fetch_retry_delay_seconds,

tests/test_polling.py

@@ -4031,6 +4031,31 @@ def test_wait_for_job_result_accepts_fraction_timing_values():
     assert result == {"ok": True}
 
 
+def test_wait_for_job_result_allows_max_length_operation_name():
+    fetch_attempts = {"count": 0}
+
+    def fetch_result() -> dict:
+        fetch_attempts["count"] += 1
+        if fetch_attempts["count"] < 2:
+            raise ValueError("temporary fetch failure")
+        return {"ok": True}
+
+    result = wait_for_job_result(
+        operation_name="x" * 200,
+        get_status=lambda: "completed",
+        is_terminal_status=lambda value: value == "completed",
+        fetch_result=fetch_result,
+        poll_interval_seconds=0.0001,
+        max_wait_seconds=1.0,
+        max_status_failures=2,
+        fetch_max_attempts=2,
+        fetch_retry_delay_seconds=0.0001,
+    )
+
+    assert result == {"ok": True}
+    assert fetch_attempts["count"] == 2
+
+
 def test_wait_for_job_result_status_polling_failures_short_circuit_fetch():
     status_attempts = {"count": 0}
     fetch_attempts = {"count": 0}
@@ -5017,6 +5042,34 @@ async def run() -> None:
     asyncio.run(run())
 
 
+def test_wait_for_job_result_async_allows_max_length_operation_name():
+    async def run() -> None:
+        fetch_attempts = {"count": 0}
+
+        async def fetch_result() -> dict:
+            fetch_attempts["count"] += 1
+            if fetch_attempts["count"] < 2:
+                raise ValueError("temporary fetch failure")
+            return {"ok": True}
+
+        result = await wait_for_job_result_async(
+            operation_name="x" * 200,
+            get_status=lambda: asyncio.sleep(0, result="completed"),
+            is_terminal_status=lambda value: value == "completed",
+            fetch_result=fetch_result,
+            poll_interval_seconds=0.0001,
+            max_wait_seconds=1.0,
+            max_status_failures=2,
+            fetch_max_attempts=2,
+            fetch_retry_delay_seconds=0.0001,
+        )
+
+        assert result == {"ok": True}
+        assert fetch_attempts["count"] == 2
+
+    asyncio.run(run())
+
+
 def test_wait_for_job_result_async_status_polling_failures_short_circuit_fetch():
     async def run() -> None:
         status_attempts = {"count": 0}