Validate extension create params model type

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/async_manager/extension.py

@@ -11,6 +11,8 @@ def __init__(self, client):
         self._client = client
 
     async def create(self, params: CreateExtensionParams) -> ExtensionResponse:
+        if not isinstance(params, CreateExtensionParams):
+            raise HyperbrowserError("params must be CreateExtensionParams")
         raw_file_path = params.file_path
         payload = params.model_dump(exclude_none=True, by_alias=True)
         payload.pop("filePath", None)

hyperbrowser/client/managers/sync_manager/extension.py

@@ -11,6 +11,8 @@ def __init__(self, client):
         self._client = client
 
     def create(self, params: CreateExtensionParams) -> ExtensionResponse:
+        if not isinstance(params, CreateExtensionParams):
+            raise HyperbrowserError("params must be CreateExtensionParams")
         raw_file_path = params.file_path
         payload = params.model_dump(exclude_none=True, by_alias=True)
         payload.pop("filePath", None)

tests/test_extension_manager.py

@@ -214,6 +214,13 @@ def get(self, url, params=None, follow_redirects=False):
         manager.list()
 
 
+def test_sync_extension_create_rejects_invalid_params_type():
+    manager = SyncExtensionManager(_FakeClient(_SyncTransport()))
+
+    with pytest.raises(HyperbrowserError, match="params must be CreateExtensionParams"):
+        manager.create({"name": "bad", "filePath": "/tmp/ext.zip"})  # type: ignore[arg-type]
+
+
 def test_async_extension_list_raises_for_invalid_payload_shape():
     class _InvalidAsyncTransport:
         async def get(self, url, params=None, follow_redirects=False):
@@ -228,3 +235,17 @@ async def run():
             await manager.list()
 
     asyncio.run(run())
+
+
+def test_async_extension_create_rejects_invalid_params_type():
+    manager = AsyncExtensionManager(_FakeClient(_AsyncTransport()))
+
+    async def run():
+        with pytest.raises(
+            HyperbrowserError, match="params must be CreateExtensionParams"
+        ):
+            await manager.create(
+                {"name": "bad", "filePath": "/tmp/ext.zip"}  # type: ignore[arg-type]
+            )
+
+    asyncio.run(run())