Truncate extremely long request URLs in error messages

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/transport/error_utils.py

@@ -6,6 +6,7 @@
 
 _HTTP_METHOD_TOKEN_PATTERN = re.compile(r"^[!#$%&'*+\-.^_`|~0-9A-Z]+$")
 _MAX_ERROR_MESSAGE_LENGTH = 2000
+_MAX_REQUEST_URL_DISPLAY_LENGTH = 1000
 
 
 def _normalize_request_method(method: Any) -> str:
@@ -29,6 +30,8 @@ def _normalize_request_url(url: Any) -> str:
         ord(character) < 32 or ord(character) == 127 for character in normalized_url
     ):
         return "unknown URL"
+    if len(normalized_url) > _MAX_REQUEST_URL_DISPLAY_LENGTH:
+        return f"{normalized_url[:_MAX_REQUEST_URL_DISPLAY_LENGTH]}... (truncated)"
     return normalized_url
 
 

tests/test_transport_error_utils.py

@@ -204,6 +204,18 @@ def test_format_request_failure_message_normalizes_lowercase_fallback_method():
     assert message == "Request POST https://example.com/fallback failed"
 
 
+def test_format_request_failure_message_truncates_very_long_fallback_urls():
+    very_long_url = "https://example.com/" + ("a" * 1200)
+    message = format_request_failure_message(
+        httpx.RequestError("network down"),
+        fallback_method="GET",
+        fallback_url=very_long_url,
+    )
+
+    assert "Request GET https://example.com/" in message
+    assert "... (truncated) failed" in message
+
+
 def test_extract_error_message_handles_recursive_list_payloads():
     recursive_payload = []
     recursive_payload.append(recursive_payload)