Wrap default factory failures in serialization helper

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/serialization_utils.py

@@ -51,7 +51,18 @@ def serialize_model_dump_or_default(
     exclude_none: bool = True,
     by_alias: bool = True,
 ) -> Dict[str, Any]:
-    model_obj = model if model is not None else default_factory()
+    if model is not None:
+        model_obj = model
+    else:
+        try:
+            model_obj = default_factory()
+        except HyperbrowserError:
+            raise
+        except Exception as exc:
+            raise HyperbrowserError(
+                error_message,
+                original_error=exc,
+            ) from exc
     return serialize_model_dump_to_dict(
         model_obj,
         error_message=error_message,

tests/test_manager_serialization_utils.py

@@ -137,3 +137,31 @@ def _default_factory():
     assert provided_model.calls == [(False, False)]
     assert default_model.calls == []
     assert default_factory_called is False
+
+
+def test_serialize_model_dump_or_default_wraps_default_factory_errors():
+    def _broken_default_factory():
+        raise RuntimeError("default factory failed")
+
+    with pytest.raises(HyperbrowserError, match="serialize failure") as exc_info:
+        serialize_model_dump_or_default(
+            None,
+            default_factory=_broken_default_factory,
+            error_message="serialize failure",
+        )
+
+    assert isinstance(exc_info.value.original_error, RuntimeError)
+
+
+def test_serialize_model_dump_or_default_preserves_hyperbrowser_default_factory_errors():
+    def _broken_default_factory():
+        raise HyperbrowserError("custom default failure")
+
+    with pytest.raises(HyperbrowserError, match="custom default failure") as exc_info:
+        serialize_model_dump_or_default(
+            None,
+            default_factory=_broken_default_factory,
+            error_message="serialize failure",
+        )
+
+    assert exc_info.value.original_error is None