Validate polling helper numeric input types

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/polling.py

@@ -1,4 +1,5 @@
 import asyncio
+from numbers import Real
 import time
 from typing import Awaitable, Callable, Optional, TypeVar
 
@@ -17,20 +18,39 @@ def _validate_retry_config(
     retry_delay_seconds: float,
     max_status_failures: Optional[int] = None,
 ) -> None:
+    if isinstance(max_attempts, bool) or not isinstance(max_attempts, int):
+        raise HyperbrowserError("max_attempts must be an integer")
     if max_attempts < 1:
         raise HyperbrowserError("max_attempts must be at least 1")
+    if isinstance(retry_delay_seconds, bool) or not isinstance(
+        retry_delay_seconds, Real
+    ):
+        raise HyperbrowserError("retry_delay_seconds must be a number")
     if retry_delay_seconds < 0:
         raise HyperbrowserError("retry_delay_seconds must be non-negative")
-    if max_status_failures is not None and max_status_failures < 1:
-        raise HyperbrowserError("max_status_failures must be at least 1")
+    if max_status_failures is not None:
+        if isinstance(max_status_failures, bool) or not isinstance(
+            max_status_failures, int
+        ):
+            raise HyperbrowserError("max_status_failures must be an integer")
+        if max_status_failures < 1:
+            raise HyperbrowserError("max_status_failures must be at least 1")
 
 
 def _validate_poll_interval(poll_interval_seconds: float) -> None:
+    if isinstance(poll_interval_seconds, bool) or not isinstance(
+        poll_interval_seconds, Real
+    ):
+        raise HyperbrowserError("poll_interval_seconds must be a number")
     if poll_interval_seconds < 0:
         raise HyperbrowserError("poll_interval_seconds must be non-negative")
 
 
 def _validate_max_wait_seconds(max_wait_seconds: Optional[float]) -> None:
+    if max_wait_seconds is not None and (
+        isinstance(max_wait_seconds, bool) or not isinstance(max_wait_seconds, Real)
+    ):
+        raise HyperbrowserError("max_wait_seconds must be a number")
     if max_wait_seconds is not None and max_wait_seconds < 0:
         raise HyperbrowserError("max_wait_seconds must be non-negative")
 

tests/test_polling.py

@@ -394,6 +394,14 @@ def test_polling_helpers_validate_retry_and_interval_configuration():
             retry_delay_seconds=0,
         )
 
+    with pytest.raises(HyperbrowserError, match="max_attempts must be an integer"):
+        retry_operation(
+            operation_name="invalid-retry-type",
+            operation=lambda: "ok",
+            max_attempts=1.5,  # type: ignore[arg-type]
+            retry_delay_seconds=0,
+        )
+
     with pytest.raises(
         HyperbrowserError, match="retry_delay_seconds must be non-negative"
     ):
@@ -416,6 +424,18 @@ def test_polling_helpers_validate_retry_and_interval_configuration():
             max_status_failures=0,
         )
 
+    with pytest.raises(
+        HyperbrowserError, match="max_status_failures must be an integer"
+    ):
+        poll_until_terminal_status(
+            operation_name="invalid-status-failures-type",
+            get_status=lambda: "completed",
+            is_terminal_status=lambda value: value == "completed",
+            poll_interval_seconds=0.1,
+            max_wait_seconds=1.0,
+            max_status_failures=1.5,  # type: ignore[arg-type]
+        )
+
     with pytest.raises(
         HyperbrowserError, match="poll_interval_seconds must be non-negative"
     ):
@@ -427,6 +447,17 @@ def test_polling_helpers_validate_retry_and_interval_configuration():
             max_wait_seconds=1.0,
         )
 
+    with pytest.raises(
+        HyperbrowserError, match="poll_interval_seconds must be a number"
+    ):
+        poll_until_terminal_status(
+            operation_name="invalid-poll-interval-type",
+            get_status=lambda: "completed",
+            is_terminal_status=lambda value: value == "completed",
+            poll_interval_seconds="0.1",  # type: ignore[arg-type]
+            max_wait_seconds=1.0,
+        )
+
     with pytest.raises(
         HyperbrowserError, match="max_wait_seconds must be non-negative"
     ):
@@ -440,3 +471,15 @@ def test_polling_helpers_validate_retry_and_interval_configuration():
             max_attempts=1,
             retry_delay_seconds=0.0,
         )
+
+    with pytest.raises(HyperbrowserError, match="max_wait_seconds must be a number"):
+        collect_paginated_results(
+            operation_name="invalid-max-wait-type",
+            get_next_page=lambda page: {"current": 1, "total": 1, "items": []},
+            get_current_page_batch=lambda response: response["current"],
+            get_total_page_batches=lambda response: response["total"],
+            on_page_success=lambda response: None,
+            max_wait_seconds="1",  # type: ignore[arg-type]
+            max_attempts=1,
+            retry_delay_seconds=0.0,
+        )