Skip to content

Commit 6a38bf4

Browse files
Tighten extension key-display import boundary assertions
Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>
1 parent d3dbb23 commit 6a38bf4

File tree

1 file changed

+17
-0
lines changed

1 file changed

+17
-0
lines changed

tests/test_extension_key_display_import_boundary.py

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,23 @@ def _imports_format_string_key_for_error(module_text: str) -> bool:
2121
return False
2222

2323

24+
def _imports_safe_key_display_for_error(module_text: str) -> bool:
25+
module_ast = ast.parse(module_text)
26+
for node in module_ast.body:
27+
if not isinstance(node, ast.ImportFrom):
28+
continue
29+
if node.module != "hyperbrowser.mapping_utils":
30+
continue
31+
if any(alias.name == "safe_key_display_for_error" for alias in node.names):
32+
return True
33+
return False
34+
35+
2436
def test_extension_key_display_helper_is_imported_from_display_utils():
2537
module_text = EXTENSION_UTILS_MODULE.read_text(encoding="utf-8")
2638
assert _imports_format_string_key_for_error(module_text)
39+
40+
41+
def test_extension_safe_key_display_helper_is_imported_from_mapping_utils():
42+
module_text = EXTENSION_UTILS_MODULE.read_text(encoding="utf-8")
43+
assert _imports_safe_key_display_for_error(module_text)

0 commit comments

Comments
 (0)