Skip to content

Commit 6c78308

Browse files
Add extension key-display helper usage guard
Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>
1 parent 7c3b1a3 commit 6c78308

3 files changed

Lines changed: 17 additions & 0 deletions

File tree

CONTRIBUTING.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@ This runs lint, format checks, compile checks, tests, and package build.
131131
- `tests/test_examples_syntax.py` (example script syntax guardrail),
132132
- `tests/test_extension_create_helper_usage.py` (extension create-input normalization helper usage enforcement),
133133
- `tests/test_extension_create_metadata_usage.py` (extension create-helper shared operation-metadata prefix usage enforcement),
134+
- `tests/test_extension_key_display_helper_usage.py` (extension missing-key display helper usage enforcement),
134135
- `tests/test_extension_operation_metadata_import_boundary.py` (extension operation-metadata import boundary enforcement),
135136
- `tests/test_extension_operation_metadata_usage.py` (extension manager operation-metadata usage enforcement),
136137
- `tests/test_extension_parse_usage_boundary.py` (centralized extension list parse-helper usage boundary enforcement),

tests/test_architecture_marker_usage.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@
107107
"tests/test_extension_operation_metadata_import_boundary.py",
108108
"tests/test_extension_operation_metadata_usage.py",
109109
"tests/test_extension_parse_usage_boundary.py",
110+
"tests/test_extension_key_display_helper_usage.py",
110111
"tests/test_extension_request_function_parse_boundary.py",
111112
"tests/test_extension_request_helper_usage.py",
112113
"tests/test_extension_request_internal_reuse.py",
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
from pathlib import Path
2+
3+
import pytest
4+
5+
pytestmark = pytest.mark.architecture
6+
7+
EXTENSION_UTILS_MODULE = Path("hyperbrowser/client/managers/extension_utils.py")
8+
9+
10+
def test_extension_utils_uses_format_string_key_for_error():
11+
module_text = EXTENSION_UTILS_MODULE.read_text(encoding="utf-8")
12+
13+
assert "format_string_key_for_error(" in module_text
14+
assert "_MAX_DISPLAYED_MISSING_KEY_LENGTH" in module_text
15+
assert "_safe_stringify_key(" in module_text

0 commit comments

Comments
 (0)