Require concrete int HTTP status codes in transport responses

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/transport/async_transport.py

@@ -34,7 +34,7 @@ def __init__(self, api_key: str, headers: Optional[Mapping[str, str]] = None):
     def _normalize_response_status_code(self, response: httpx.Response) -> int:
         try:
             status_code = response.status_code
-            if isinstance(status_code, bool) or not isinstance(status_code, int):
+            if type(status_code) is not int:
                 raise TypeError("status code must be an integer")
             normalized_status_code = status_code
             if not (

hyperbrowser/transport/base.py

@@ -116,7 +116,7 @@ class APIResponse(Generic[T]):
     """
 
     def __init__(self, data: Optional[Union[dict, T]] = None, status_code: int = 200):
-        if isinstance(status_code, bool) or not isinstance(status_code, int):
+        if type(status_code) is not int:
             raise HyperbrowserError("status_code must be an integer")
         if not (_MIN_HTTP_STATUS_CODE <= status_code <= _MAX_HTTP_STATUS_CODE):
             raise HyperbrowserError("status_code must be between 100 and 599")

hyperbrowser/transport/sync.py

@@ -33,7 +33,7 @@ def __init__(self, api_key: str, headers: Optional[Mapping[str, str]] = None):
     def _normalize_response_status_code(self, response: httpx.Response) -> int:
         try:
             status_code = response.status_code
-            if isinstance(status_code, bool) or not isinstance(status_code, int):
+            if type(status_code) is not int:
                 raise TypeError("status code must be an integer")
             normalized_status_code = status_code
             if not (

tests/test_transport_base.py

@@ -145,6 +145,10 @@ def __getitem__(self, key: str) -> object:
         raise KeyError(key)
 
 
+class _StatusCodeIntSubclass(int):
+    pass
+
+
 def test_api_response_from_json_parses_model_data() -> None:
     response = APIResponse.from_json(
         {"name": "job-1", "retries": 2}, _SampleResponseModel
@@ -345,6 +349,11 @@ def test_api_response_constructor_rejects_boolean_status_code() -> None:
         APIResponse(status_code=True)
 
 
+def test_api_response_constructor_rejects_integer_subclass_status_code() -> None:
+    with pytest.raises(HyperbrowserError, match="status_code must be an integer"):
+        APIResponse(status_code=_StatusCodeIntSubclass(200))
+
+
 @pytest.mark.parametrize("status_code", [99, 600])
 def test_api_response_constructor_rejects_out_of_range_status_code(
     status_code: int,
@@ -360,6 +369,11 @@ def test_api_response_from_status_rejects_boolean_status_code() -> None:
         APIResponse.from_status(True)  # type: ignore[arg-type]
 
 
+def test_api_response_from_status_rejects_integer_subclass_status_code() -> None:
+    with pytest.raises(HyperbrowserError, match="status_code must be an integer"):
+        APIResponse.from_status(_StatusCodeIntSubclass(200))
+
+
 @pytest.mark.parametrize("status_code", [99, 600])
 def test_api_response_from_status_rejects_out_of_range_status_code(
     status_code: int,

tests/test_transport_response_handling.py

@@ -106,6 +106,22 @@ def json(self):
         return {}
 
 
+class _IntegerSubclassStatusNoContentResponse:
+    content = b""
+    text = ""
+
+    class _StatusCode(int):
+        pass
+
+    status_code = _StatusCode(200)
+
+    def raise_for_status(self) -> None:
+        return None
+
+    def json(self):
+        return {}
+
+
 class _BrokenStatusCodeHttpErrorResponse:
     content = b""
     text = "status error"
@@ -231,6 +247,19 @@ def test_sync_handle_response_with_non_integer_status_raises_hyperbrowser_error(
         transport.close()
 
 
+def test_sync_handle_response_with_integer_subclass_status_raises_hyperbrowser_error():
+    transport = SyncTransport(api_key="test-key")
+    try:
+        with pytest.raises(
+            HyperbrowserError, match="Failed to process response status code"
+        ):
+            transport._handle_response(
+                _IntegerSubclassStatusNoContentResponse()  # type: ignore[arg-type]
+            )
+    finally:
+        transport.close()
+
+
 def test_sync_handle_response_with_request_error_includes_method_and_url():
     transport = SyncTransport(api_key="test-key")
     try:
@@ -420,6 +449,22 @@ async def run() -> None:
     asyncio.run(run())
 
 
+def test_async_handle_response_with_integer_subclass_status_raises_hyperbrowser_error():
+    async def run() -> None:
+        transport = AsyncTransport(api_key="test-key")
+        try:
+            with pytest.raises(
+                HyperbrowserError, match="Failed to process response status code"
+            ):
+                await transport._handle_response(
+                    _IntegerSubclassStatusNoContentResponse()  # type: ignore[arg-type]
+                )
+        finally:
+            await transport.close()
+
+    asyncio.run(run())
+
+
 def test_async_handle_response_with_request_error_includes_method_and_url():
     async def run() -> None:
         transport = AsyncTransport(api_key="test-key")