Validate polling status callbacks return strings

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/polling.py

@@ -54,6 +54,12 @@ def _ensure_boolean_terminal_result(result: object, *, operation_name: str) -> b
     return result
 
 
+def _ensure_status_string(status: object, *, operation_name: str) -> str:
+    if not isinstance(status, str):
+        raise HyperbrowserError(f"get_status must return a string for {operation_name}")
+    return status
+
+
 def _validate_retry_config(
     *,
     max_attempts: int,
@@ -147,7 +153,7 @@ def poll_until_terminal_status(
 
     while True:
         try:
-            status = get_status()
+            status = _ensure_status_string(get_status(), operation_name=operation_name)
             failures = 0
         except Exception as exc:
             failures += 1
@@ -220,7 +226,9 @@ async def poll_until_terminal_status_async(
 
     while True:
         try:
-            status = await get_status()
+            status = _ensure_status_string(
+                await get_status(), operation_name=operation_name
+            )
             failures = 0
         except Exception as exc:
             failures += 1

tests/test_polling.py

@@ -772,6 +772,14 @@ def test_polling_helpers_validate_retry_and_interval_configuration():
             poll_interval_seconds=0.0,
             max_wait_seconds=1.0,
         )
+    with pytest.raises(HyperbrowserError, match="get_status must return a string"):
+        poll_until_terminal_status(
+            operation_name="invalid-status-value",
+            get_status=lambda: 123,  # type: ignore[return-value]
+            is_terminal_status=lambda value: value == "completed",
+            poll_interval_seconds=0.0,
+            max_wait_seconds=1.0,
+        )
 
     with pytest.raises(
         HyperbrowserError, match="max_wait_seconds must be non-negative"
@@ -878,6 +886,14 @@ async def validate_async_operation_name() -> None:
                 poll_interval_seconds=0.0,
                 max_wait_seconds=1.0,
             )
+        with pytest.raises(HyperbrowserError, match="get_status must return a string"):
+            await poll_until_terminal_status_async(
+                operation_name="invalid-status-value-async",
+                get_status=lambda: asyncio.sleep(0, result=123),  # type: ignore[arg-type]
+                is_terminal_status=lambda value: value == "completed",
+                poll_interval_seconds=0.0,
+                max_wait_seconds=1.0,
+            )
         with pytest.raises(
             HyperbrowserError, match="operation_name must be 200 characters or fewer"
         ):