Adopt shared display normalization in parsers

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/extension_utils.py

@@ -1,13 +1,13 @@
 from collections.abc import Mapping
 from typing import Any, List
 
+from hyperbrowser.display_utils import normalize_display_text
 from hyperbrowser.exceptions import HyperbrowserError
 from hyperbrowser.models.extension import ExtensionResponse
 from .list_parsing_utils import parse_mapping_list_items
 
 _MAX_DISPLAYED_MISSING_KEYS = 20
 _MAX_DISPLAYED_MISSING_KEY_LENGTH = 120
-_TRUNCATED_KEY_DISPLAY_SUFFIX = "... (truncated)"
 
 
 def _get_type_name(value: Any) -> str:
@@ -29,24 +29,15 @@ def _format_key_display(value: object) -> str:
         normalized_key = _safe_stringify_key(value)
         if type(normalized_key) is not str:
             raise TypeError("normalized key display must be a string")
-        normalized_key = "".join(
-            "?" if ord(character) < 32 or ord(character) == 127 else character
-            for character in normalized_key
-        ).strip()
-        if type(normalized_key) is not str:
-            raise TypeError("normalized key display must be a string")
     except Exception:
         return "<unreadable key>"
+    normalized_key = normalize_display_text(
+        normalized_key,
+        max_length=_MAX_DISPLAYED_MISSING_KEY_LENGTH,
+    )
     if not normalized_key:
         return "<blank key>"
-    if len(normalized_key) <= _MAX_DISPLAYED_MISSING_KEY_LENGTH:
-        return normalized_key
-    available_key_length = _MAX_DISPLAYED_MISSING_KEY_LENGTH - len(
-        _TRUNCATED_KEY_DISPLAY_SUFFIX
-    )
-    if available_key_length <= 0:
-        return _TRUNCATED_KEY_DISPLAY_SUFFIX
-    return f"{normalized_key[:available_key_length]}{_TRUNCATED_KEY_DISPLAY_SUFFIX}"
+    return normalized_key
 
 
 def _summarize_mapping_keys(mapping: Mapping[object, object]) -> str:

hyperbrowser/client/managers/session_utils.py

@@ -1,33 +1,23 @@
 from typing import Any, List, Type, TypeVar
 
+from hyperbrowser.display_utils import normalize_display_text
 from hyperbrowser.exceptions import HyperbrowserError
 from hyperbrowser.models.session import SessionRecording
 from .list_parsing_utils import parse_mapping_list_items
 from .response_utils import parse_response_model
 
 T = TypeVar("T")
 _MAX_KEY_DISPLAY_LENGTH = 120
-_TRUNCATED_KEY_DISPLAY_SUFFIX = "... (truncated)"
 
 
 def _format_recording_key_display(key: str) -> str:
-    try:
-        normalized_key = "".join(
-            "?" if ord(character) < 32 or ord(character) == 127 else character
-            for character in key
-        ).strip()
-        if type(normalized_key) is not str:
-            raise TypeError("normalized recording key display must be a string")
-    except Exception:
-        return "<unreadable key>"
+    normalized_key = normalize_display_text(
+        key,
+        max_length=_MAX_KEY_DISPLAY_LENGTH,
+    )
     if not normalized_key:
         return "<blank key>"
-    if len(normalized_key) <= _MAX_KEY_DISPLAY_LENGTH:
-        return normalized_key
-    available_length = _MAX_KEY_DISPLAY_LENGTH - len(_TRUNCATED_KEY_DISPLAY_SUFFIX)
-    if available_length <= 0:
-        return _TRUNCATED_KEY_DISPLAY_SUFFIX
-    return f"{normalized_key[:available_length]}{_TRUNCATED_KEY_DISPLAY_SUFFIX}"
+    return normalized_key
 
 
 def parse_session_response_model(

hyperbrowser/tools/__init__.py

@@ -3,6 +3,7 @@
 from collections.abc import Mapping as MappingABC
 from typing import Any, Callable, Dict, Mapping
 
+from hyperbrowser.display_utils import normalize_display_text
 from hyperbrowser.exceptions import HyperbrowserError
 from hyperbrowser.models.agents.browser_use import StartBrowserUseTaskParams
 from hyperbrowser.models.crawl import StartCrawlJobParams
@@ -26,7 +27,6 @@
 )
 
 _MAX_KEY_DISPLAY_LENGTH = 120
-_TRUNCATED_KEY_DISPLAY_SUFFIX = "... (truncated)"
 _NON_OBJECT_CRAWL_PAGE_TYPES = (
     str,
     bytes,
@@ -53,23 +53,13 @@ def _has_declared_attribute(
 
 
 def _format_tool_param_key_for_error(key: str) -> str:
-    try:
-        normalized_key = "".join(
-            "?" if ord(character) < 32 or ord(character) == 127 else character
-            for character in key
-        ).strip()
-        if type(normalized_key) is not str:
-            raise TypeError("normalized tool key display must be a string")
-    except Exception:
-        return "<unreadable key>"
+    normalized_key = normalize_display_text(
+        key,
+        max_length=_MAX_KEY_DISPLAY_LENGTH,
+    )
     if not normalized_key:
         return "<blank key>"
-    if len(normalized_key) <= _MAX_KEY_DISPLAY_LENGTH:
-        return normalized_key
-    available_length = _MAX_KEY_DISPLAY_LENGTH - len(_TRUNCATED_KEY_DISPLAY_SUFFIX)
-    if available_length <= 0:
-        return _TRUNCATED_KEY_DISPLAY_SUFFIX
-    return f"{normalized_key[:available_length]}{_TRUNCATED_KEY_DISPLAY_SUFFIX}"
+    return normalized_key
 
 
 def _copy_mapping_values_by_keys(