Wrap broken file-like state access in upload validation

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/async_manager/session.py

@@ -133,18 +133,33 @@ async def upload_file(
                     f"Failed to open upload file at path: {file_path}",
                     original_error=exc,
                 ) from exc
-        elif callable(getattr(file_input, "read", None)):
-            if getattr(file_input, "closed", False):
-                raise HyperbrowserError("file_input file-like object must be open")
-            files = {"file": file_input}
-            response = await self._client.transport.post(
-                self._client._build_url(f"/session/{id}/uploads"),
-                files=files,
-            )
         else:
-            raise HyperbrowserError(
-                "file_input must be a file path or file-like object"
-            )
+            try:
+                read_method = getattr(file_input, "read", None)
+            except Exception as exc:
+                raise HyperbrowserError(
+                    "file_input file-like object state is invalid",
+                    original_error=exc,
+                ) from exc
+            if callable(read_method):
+                try:
+                    is_closed = bool(getattr(file_input, "closed", False))
+                except Exception as exc:
+                    raise HyperbrowserError(
+                        "file_input file-like object state is invalid",
+                        original_error=exc,
+                    ) from exc
+                if is_closed:
+                    raise HyperbrowserError("file_input file-like object must be open")
+                files = {"file": file_input}
+                response = await self._client.transport.post(
+                    self._client._build_url(f"/session/{id}/uploads"),
+                    files=files,
+                )
+            else:
+                raise HyperbrowserError(
+                    "file_input must be a file path or file-like object"
+                )
 
         return UploadFileResponse(**response.data)
 

hyperbrowser/client/managers/sync_manager/session.py

@@ -125,18 +125,33 @@ def upload_file(
                     f"Failed to open upload file at path: {file_path}",
                     original_error=exc,
                 ) from exc
-        elif callable(getattr(file_input, "read", None)):
-            if getattr(file_input, "closed", False):
-                raise HyperbrowserError("file_input file-like object must be open")
-            files = {"file": file_input}
-            response = self._client.transport.post(
-                self._client._build_url(f"/session/{id}/uploads"),
-                files=files,
-            )
         else:
-            raise HyperbrowserError(
-                "file_input must be a file path or file-like object"
-            )
+            try:
+                read_method = getattr(file_input, "read", None)
+            except Exception as exc:
+                raise HyperbrowserError(
+                    "file_input file-like object state is invalid",
+                    original_error=exc,
+                ) from exc
+            if callable(read_method):
+                try:
+                    is_closed = bool(getattr(file_input, "closed", False))
+                except Exception as exc:
+                    raise HyperbrowserError(
+                        "file_input file-like object state is invalid",
+                        original_error=exc,
+                    ) from exc
+                if is_closed:
+                    raise HyperbrowserError("file_input file-like object must be open")
+                files = {"file": file_input}
+                response = self._client.transport.post(
+                    self._client._build_url(f"/session/{id}/uploads"),
+                    files=files,
+                )
+            else:
+                raise HyperbrowserError(
+                    "file_input must be a file path or file-like object"
+                )
 
         return UploadFileResponse(**response.data)
 

tests/test_session_upload_file.py

@@ -157,6 +157,18 @@ def test_sync_session_upload_file_rejects_closed_file_like_object():
         manager.upload_file("session_123", closed_file_obj)
 
 
+def test_sync_session_upload_file_wraps_invalid_file_like_state_errors():
+    manager = SyncSessionManager(_FakeClient(_SyncTransport()))
+
+    class _BrokenFileLike:
+        @property
+        def read(self):
+            raise RuntimeError("broken read")
+
+    with pytest.raises(HyperbrowserError, match="file-like object state is invalid"):
+        manager.upload_file("session_123", _BrokenFileLike())
+
+
 def test_async_session_upload_file_rejects_non_callable_read_attribute():
     manager = AsyncSessionManager(_FakeClient(_AsyncTransport()))
     fake_file = type("FakeFile", (), {"read": "not-callable"})()
@@ -180,6 +192,23 @@ async def run():
     asyncio.run(run())
 
 
+def test_async_session_upload_file_wraps_invalid_file_like_state_errors():
+    manager = AsyncSessionManager(_FakeClient(_AsyncTransport()))
+
+    class _BrokenFileLike:
+        @property
+        def read(self):
+            raise RuntimeError("broken read")
+
+    async def run():
+        with pytest.raises(
+            HyperbrowserError, match="file-like object state is invalid"
+        ):
+            await manager.upload_file("session_123", _BrokenFileLike())
+
+    asyncio.run(run())
+
+
 def test_sync_session_upload_file_raises_hyperbrowser_error_for_missing_path(tmp_path):
     manager = SyncSessionManager(_FakeClient(_SyncTransport()))
     missing_path = tmp_path / "missing-file.txt"