Centralize profile route builder usage

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

CONTRIBUTING.md

@@ -136,6 +136,7 @@ This runs lint, format checks, compile checks, tests, and package build.
   - `tests/test_polling_loop_usage.py` (`while True` polling-loop centralization in `hyperbrowser/client/polling.py`),
   - `tests/test_profile_operation_metadata_usage.py` (profile manager operation-metadata usage enforcement),
   - `tests/test_profile_request_helper_usage.py` (profile manager request-helper usage enforcement),
+  - `tests/test_profile_route_builder_usage.py` (profile request-helper route-builder usage enforcement),
   - `tests/test_profile_route_constants_usage.py` (profile manager route-constant usage enforcement),
   - `tests/test_pyproject_architecture_marker.py` (pytest marker registration enforcement),
   - `tests/test_readme_examples_listing.py` (README example-listing consistency enforcement),

hyperbrowser/client/managers/async_manager/profile.py

@@ -48,7 +48,6 @@ async def create(
     async def get(self, id: str) -> ProfileResponse:
         return await get_profile_resource_async(
             client=self._client,
-            route_prefix=self._ROUTE_PREFIX,
             profile_id=id,
             model=ProfileResponse,
             operation_name=self._OPERATION_METADATA.get_operation_name,
@@ -57,7 +56,6 @@ async def get(self, id: str) -> ProfileResponse:
     async def delete(self, id: str) -> BasicResponse:
         return await delete_profile_resource_async(
             client=self._client,
-            route_prefix=self._ROUTE_PREFIX,
             profile_id=id,
             model=BasicResponse,
             operation_name=self._OPERATION_METADATA.delete_operation_name,

hyperbrowser/client/managers/profile_request_utils.py

@@ -1,5 +1,6 @@
 from typing import Any, Dict, Optional, Type, TypeVar
 
+from .profile_route_constants import build_profile_route
 from .response_utils import parse_response_model
 
 T = TypeVar("T")
@@ -27,13 +28,12 @@ def create_profile_resource(
 def get_profile_resource(
     *,
     client: Any,
-    route_prefix: str,
     profile_id: str,
     model: Type[T],
     operation_name: str,
 ) -> T:
     response = client.transport.get(
-        client._build_url(f"{route_prefix}/{profile_id}"),
+        client._build_url(build_profile_route(profile_id)),
     )
     return parse_response_model(
         response.data,
@@ -45,13 +45,12 @@ def get_profile_resource(
 def delete_profile_resource(
     *,
     client: Any,
-    route_prefix: str,
     profile_id: str,
     model: Type[T],
     operation_name: str,
 ) -> T:
     response = client.transport.delete(
-        client._build_url(f"{route_prefix}/{profile_id}"),
+        client._build_url(build_profile_route(profile_id)),
     )
     return parse_response_model(
         response.data,
@@ -101,13 +100,12 @@ async def create_profile_resource_async(
 async def get_profile_resource_async(
     *,
     client: Any,
-    route_prefix: str,
     profile_id: str,
     model: Type[T],
     operation_name: str,
 ) -> T:
     response = await client.transport.get(
-        client._build_url(f"{route_prefix}/{profile_id}"),
+        client._build_url(build_profile_route(profile_id)),
     )
     return parse_response_model(
         response.data,
@@ -119,13 +117,12 @@ async def get_profile_resource_async(
 async def delete_profile_resource_async(
     *,
     client: Any,
-    route_prefix: str,
     profile_id: str,
     model: Type[T],
     operation_name: str,
 ) -> T:
     response = await client.transport.delete(
-        client._build_url(f"{route_prefix}/{profile_id}"),
+        client._build_url(build_profile_route(profile_id)),
     )
     return parse_response_model(
         response.data,

hyperbrowser/client/managers/profile_route_constants.py

@@ -1,2 +1,6 @@
 PROFILE_ROUTE_PREFIX = "/profile"
 PROFILES_ROUTE_PATH = "/profiles"
+
+
+def build_profile_route(profile_id: str) -> str:
+    return f"{PROFILE_ROUTE_PREFIX}/{profile_id}"

hyperbrowser/client/managers/sync_manager/profile.py

@@ -48,7 +48,6 @@ def create(
     def get(self, id: str) -> ProfileResponse:
         return get_profile_resource(
             client=self._client,
-            route_prefix=self._ROUTE_PREFIX,
             profile_id=id,
             model=ProfileResponse,
             operation_name=self._OPERATION_METADATA.get_operation_name,
@@ -57,7 +56,6 @@ def get(self, id: str) -> ProfileResponse:
     def delete(self, id: str) -> BasicResponse:
         return delete_profile_resource(
             client=self._client,
-            route_prefix=self._ROUTE_PREFIX,
             profile_id=id,
             model=BasicResponse,
             operation_name=self._OPERATION_METADATA.delete_operation_name,

tests/test_architecture_marker_usage.py

@@ -39,6 +39,7 @@
     "tests/test_optional_serialization_helper_usage.py",
     "tests/test_profile_operation_metadata_usage.py",
     "tests/test_profile_request_helper_usage.py",
+    "tests/test_profile_route_builder_usage.py",
     "tests/test_profile_route_constants_usage.py",
     "tests/test_type_utils_usage.py",
     "tests/test_polling_loop_usage.py",

tests/test_profile_request_utils.py

@@ -71,7 +71,6 @@ def _fake_parse_response_model(data, **kwargs):
     try:
         result = profile_request_utils.get_profile_resource(
             client=_Client(),
-            route_prefix="/profile",
             profile_id="profile-2",
             model=object,
             operation_name="get profile",
@@ -111,7 +110,6 @@ def _fake_parse_response_model(data, **kwargs):
     try:
         result = profile_request_utils.delete_profile_resource(
             client=_Client(),
-            route_prefix="/profile",
             profile_id="profile-3",
             model=object,
             operation_name="delete profile",
@@ -236,7 +234,6 @@ def _fake_parse_response_model(data, **kwargs):
         result = asyncio.run(
             profile_request_utils.get_profile_resource_async(
                 client=_Client(),
-                route_prefix="/profile",
                 profile_id="profile-5",
                 model=object,
                 operation_name="get profile",
@@ -278,7 +275,6 @@ def _fake_parse_response_model(data, **kwargs):
         result = asyncio.run(
             profile_request_utils.delete_profile_resource_async(
                 client=_Client(),
-                route_prefix="/profile",
                 profile_id="profile-6",
                 model=object,
                 operation_name="delete profile",

tests/test_profile_route_builder_usage.py

@@ -0,0 +1,14 @@
+from pathlib import Path
+
+import pytest
+
+pytestmark = pytest.mark.architecture
+
+
+def test_profile_request_utils_use_profile_route_builder():
+    module_text = Path(
+        "hyperbrowser/client/managers/profile_request_utils.py"
+    ).read_text(encoding="utf-8")
+    assert "profile_route_constants import build_profile_route" in module_text
+    assert "build_profile_route(profile_id)" in module_text
+    assert 'f"{route_prefix}/{profile_id}"' not in module_text

tests/test_profile_route_constants.py

@@ -1,4 +1,5 @@
 from hyperbrowser.client.managers.profile_route_constants import (
+    build_profile_route,
     PROFILE_ROUTE_PREFIX,
     PROFILES_ROUTE_PATH,
 )
@@ -7,3 +8,7 @@
 def test_profile_route_constants_match_expected_api_paths():
     assert PROFILE_ROUTE_PREFIX == "/profile"
     assert PROFILES_ROUTE_PATH == "/profiles"
+
+
+def test_build_profile_route_composes_profile_path():
+    assert build_profile_route("profile_123") == "/profile/profile_123"