Validate tool parameter key hygiene

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/tools/__init__.py

@@ -72,6 +72,16 @@ def _to_param_dict(params: Mapping[str, Any]) -> Dict[str, Any]:
         ) from exc
     for key in param_keys:
         if isinstance(key, str):
+            if not key.strip():
+                raise HyperbrowserError("tool params keys must not be empty")
+            if key != key.strip():
+                raise HyperbrowserError(
+                    "tool params keys must not contain leading or trailing whitespace"
+                )
+            if any(ord(character) < 32 or ord(character) == 127 for character in key):
+                raise HyperbrowserError(
+                    "tool params keys must not contain control characters"
+                )
             continue
         raise HyperbrowserError("tool params keys must be strings")
     normalized_params: Dict[str, Any] = {}

tests/test_tools_mapping_inputs.py

@@ -108,6 +108,41 @@ def test_tool_wrappers_reject_non_string_param_keys():
         )
 
 
+def test_tool_wrappers_reject_blank_param_keys():
+    client = _Client()
+
+    with pytest.raises(HyperbrowserError, match="tool params keys must not be empty"):
+        WebsiteScrapeTool.runnable(
+            client,
+            {"   ": "https://example.com"},
+        )
+
+
+def test_tool_wrappers_reject_param_keys_with_surrounding_whitespace():
+    client = _Client()
+
+    with pytest.raises(
+        HyperbrowserError,
+        match="tool params keys must not contain leading or trailing whitespace",
+    ):
+        WebsiteScrapeTool.runnable(
+            client,
+            {" url ": "https://example.com"},
+        )
+
+
+def test_tool_wrappers_reject_param_keys_with_control_characters():
+    client = _Client()
+
+    with pytest.raises(
+        HyperbrowserError, match="tool params keys must not contain control characters"
+    ):
+        WebsiteScrapeTool.runnable(
+            client,
+            {"u\trl": "https://example.com"},
+        )
+
+
 def test_tool_wrappers_wrap_param_key_read_failures():
     class _BrokenKeyMapping(Mapping[str, object]):
         def __iter__(self) -> Iterator[str]: