Harden fetch operation-name builder with normalized fallback

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/polling.py

@@ -116,11 +116,14 @@ def build_operation_name(prefix: object, identifier: object) -> str:
     return operation_name
 
 
-def build_fetch_operation_name(operation_name: str) -> str:
-    prefixed_operation_name = f"{_FETCH_OPERATION_NAME_PREFIX}{operation_name}"
+def build_fetch_operation_name(operation_name: object) -> str:
+    normalized_operation_name = build_operation_name("", operation_name)
+    prefixed_operation_name = (
+        f"{_FETCH_OPERATION_NAME_PREFIX}{normalized_operation_name}"
+    )
     if len(prefixed_operation_name) <= _MAX_OPERATION_NAME_LENGTH:
         return prefixed_operation_name
-    return operation_name
+    return normalized_operation_name
 
 
 def _ensure_boolean_terminal_result(result: object, *, operation_name: str) -> bool:

tests/test_polling.py

@@ -52,6 +52,23 @@ def test_build_fetch_operation_name_falls_back_for_max_length_inputs():
     assert build_fetch_operation_name(operation_name) == operation_name
 
 
+def test_build_fetch_operation_name_sanitizes_non_string_and_control_input():
+    operation_name = build_fetch_operation_name(" \nabc\tdef ")
+    assert operation_name == "Fetching abc?def"
+
+    numeric_operation_name = build_fetch_operation_name(123)
+    assert numeric_operation_name == "Fetching 123"
+
+
+def test_build_fetch_operation_name_handles_unstringifiable_input():
+    class _BadOperationName:
+        def __str__(self) -> str:
+            raise RuntimeError("cannot stringify")
+
+    operation_name = build_fetch_operation_name(_BadOperationName())
+    assert operation_name == "Fetching unknown"
+
+
 def test_build_operation_name_keeps_short_names_unchanged():
     assert build_operation_name("crawl job ", "123") == "crawl job 123"