Add AST call-symbol helper usage guard

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

CONTRIBUTING.md

@@ -89,6 +89,7 @@ This runs lint, format checks, compile checks, tests, and package build.
   - `tests/test_agent_terminal_status_helper_usage.py` (shared agent terminal-status helper usage enforcement),
   - `tests/test_architecture_marker_usage.py` (architecture marker coverage across guard modules),
   - `tests/test_ast_call_symbol_helper_import_boundary.py` (shared AST call-helper import boundary enforcement across test modules),
+  - `tests/test_ast_call_symbol_helper_usage.py` (shared AST call-helper usage enforcement across AST boundary guard suites),
   - `tests/test_ast_function_source_helper_usage.py` (shared AST function-source helper usage enforcement across architecture guard suites),
   - `tests/test_ast_function_source_import_boundary.py` (shared AST function-source helper import boundary enforcement across test modules),
   - `tests/test_ast_function_source_utils.py` (shared AST function-source helper contract validation),

tests/test_architecture_marker_usage.py

@@ -18,6 +18,7 @@
     "tests/test_agent_stop_helper_usage.py",
     "tests/test_agent_terminal_status_helper_usage.py",
     "tests/test_ast_call_symbol_helper_import_boundary.py",
+    "tests/test_ast_call_symbol_helper_usage.py",
     "tests/test_ast_function_source_helper_usage.py",
     "tests/test_ast_function_source_import_boundary.py",
     "tests/test_ast_function_source_utils.py",

tests/test_ast_call_symbol_helper_import_boundary.py

@@ -8,6 +8,7 @@
 
 
 EXPECTED_CALLS_SYMBOL_IMPORTERS = (
+    "tests/test_ast_call_symbol_helper_usage.py",
     "tests/test_ast_function_source_helper_usage.py",
     "tests/test_ast_import_helper_usage.py",
     "tests/test_ast_import_utils.py",

tests/test_ast_call_symbol_helper_usage.py

@@ -0,0 +1,57 @@
+from pathlib import Path
+
+import pytest
+
+from tests.ast_import_utils import calls_symbol, imports_symbol_from_module
+
+pytestmark = pytest.mark.architecture
+
+
+AST_CALL_SYMBOL_GUARD_MODULES = (
+    "tests/test_ast_function_source_helper_usage.py",
+    "tests/test_ast_import_helper_usage.py",
+    "tests/test_ast_symbol_import_helper_usage.py",
+)
+
+
+def test_ast_call_symbol_guard_modules_reuse_shared_helper():
+    violating_modules: list[str] = []
+    for module_path in AST_CALL_SYMBOL_GUARD_MODULES:
+        module_text = Path(module_path).read_text(encoding="utf-8")
+        if not imports_symbol_from_module(
+            module_text,
+            module="tests.ast_import_utils",
+            symbol="calls_symbol",
+        ):
+            violating_modules.append(module_path)
+            continue
+        if not calls_symbol(module_text, "calls_symbol"):
+            violating_modules.append(module_path)
+            continue
+        if "def _calls_symbol" in module_text:
+            violating_modules.append(module_path)
+
+    assert violating_modules == []
+
+
+def test_ast_call_symbol_guard_inventory_stays_in_sync():
+    excluded_modules = {
+        "tests/test_ast_call_symbol_helper_import_boundary.py",
+        "tests/test_ast_call_symbol_helper_usage.py",
+        "tests/test_ast_import_utils.py",
+    }
+    discovered_modules: list[str] = []
+    for module_path in sorted(Path("tests").glob("test_*.py")):
+        normalized_path = module_path.as_posix()
+        if normalized_path in excluded_modules:
+            continue
+        module_text = module_path.read_text(encoding="utf-8")
+        if not imports_symbol_from_module(
+            module_text,
+            module="tests.ast_import_utils",
+            symbol="calls_symbol",
+        ):
+            continue
+        discovered_modules.append(normalized_path)
+
+    assert sorted(AST_CALL_SYMBOL_GUARD_MODULES) == discovered_modules

tests/test_ast_import_utils_module_import_boundary.py

@@ -16,6 +16,7 @@
 
 EXPECTED_EXTRA_IMPORTERS = (
     "tests/test_ast_call_symbol_helper_import_boundary.py",
+    "tests/test_ast_call_symbol_helper_usage.py",
     "tests/test_ast_import_helper_import_boundary.py",
     "tests/test_ast_import_helper_secondary_import_boundary.py",
     "tests/test_ast_module_import_helper_import_boundary.py",

tests/test_ast_symbol_import_helper_usage.py

@@ -9,6 +9,7 @@
 
 AST_SYMBOL_IMPORT_GUARD_MODULES = (
     "tests/test_ast_call_symbol_helper_import_boundary.py",
+    "tests/test_ast_call_symbol_helper_usage.py",
     "tests/test_ast_import_helper_secondary_import_boundary.py",
     "tests/test_ast_import_helper_usage.py",
     "tests/test_ast_module_import_helper_import_boundary.py",