Wrap extension file opening failures with HyperbrowserError

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/async_manager/extension.py

@@ -16,14 +16,20 @@ async def create(self, params: CreateExtensionParams) -> ExtensionResponse:
 
         # Check if file exists before trying to open it
         if not os.path.exists(file_path):
-            raise FileNotFoundError(f"Extension file not found at path: {file_path}")
+            raise HyperbrowserError(f"Extension file not found at path: {file_path}")
 
-        with open(file_path, "rb") as extension_file:
-            response = await self._client.transport.post(
-                self._client._build_url("/extensions/add"),
-                data=payload,
-                files={"file": extension_file},
-            )
+        try:
+            with open(file_path, "rb") as extension_file:
+                response = await self._client.transport.post(
+                    self._client._build_url("/extensions/add"),
+                    data=payload,
+                    files={"file": extension_file},
+                )
+        except OSError as exc:
+            raise HyperbrowserError(
+                f"Failed to open extension file at path: {file_path}",
+                original_error=exc,
+            ) from exc
         return ExtensionResponse(**response.data)
 
     async def list(self) -> List[ExtensionResponse]:

hyperbrowser/client/managers/sync_manager/extension.py

@@ -16,14 +16,20 @@ def create(self, params: CreateExtensionParams) -> ExtensionResponse:
 
         # Check if file exists before trying to open it
         if not os.path.exists(file_path):
-            raise FileNotFoundError(f"Extension file not found at path: {file_path}")
+            raise HyperbrowserError(f"Extension file not found at path: {file_path}")
 
-        with open(file_path, "rb") as extension_file:
-            response = self._client.transport.post(
-                self._client._build_url("/extensions/add"),
-                data=payload,
-                files={"file": extension_file},
-            )
+        try:
+            with open(file_path, "rb") as extension_file:
+                response = self._client.transport.post(
+                    self._client._build_url("/extensions/add"),
+                    data=payload,
+                    files={"file": extension_file},
+                )
+        except OSError as exc:
+            raise HyperbrowserError(
+                f"Failed to open extension file at path: {file_path}",
+                original_error=exc,
+            ) from exc
         return ExtensionResponse(**response.data)
 
     def list(self) -> List[ExtensionResponse]:

tests/test_extension_manager.py

@@ -1,12 +1,14 @@
 import asyncio
 from pathlib import Path
+import pytest
 
 from hyperbrowser.client.managers.async_manager.extension import (
     ExtensionManager as AsyncExtensionManager,
 )
 from hyperbrowser.client.managers.sync_manager.extension import (
     ExtensionManager as SyncExtensionManager,
 )
+from hyperbrowser.exceptions import HyperbrowserError
 from hyperbrowser.models.extension import CreateExtensionParams
 
 
@@ -104,3 +106,26 @@ async def run():
         transport.received_file is not None and transport.received_file.closed is True
     )
     assert transport.received_data == {"name": "my-extension"}
+
+
+def test_sync_extension_create_raises_hyperbrowser_error_when_file_missing(tmp_path):
+    transport = _SyncTransport()
+    manager = SyncExtensionManager(_FakeClient(transport))
+    missing_path = tmp_path / "missing-extension.zip"
+    params = CreateExtensionParams(name="missing-extension", file_path=missing_path)
+
+    with pytest.raises(HyperbrowserError, match="Extension file not found"):
+        manager.create(params)
+
+
+def test_async_extension_create_raises_hyperbrowser_error_when_file_missing(tmp_path):
+    transport = _AsyncTransport()
+    manager = AsyncExtensionManager(_FakeClient(transport))
+    missing_path = tmp_path / "missing-extension.zip"
+    params = CreateExtensionParams(name="missing-extension", file_path=missing_path)
+
+    async def run():
+        with pytest.raises(HyperbrowserError, match="Extension file not found"):
+            await manager.create(params)
+
+    asyncio.run(run())