Migrate architecture checks to pytest marker workflow

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

CONTRIBUTING.md

@@ -60,6 +60,8 @@ make test
 make architecture-check
 ```
 
+This runs `pytest -m architecture` against guardrail suites.
+
 ### Full local CI parity
 
 ```bash

Makefile

@@ -18,15 +18,7 @@ test:
 	$(PYTHON) -m pytest -q
 
 architecture-check:
-	$(PYTHON) -m pytest -q \
-		tests/test_guardrail_ast_utils.py \
-		tests/test_manager_model_dump_usage.py \
-		tests/test_mapping_reader_usage.py \
-		tests/test_mapping_keys_access_usage.py \
-		tests/test_tool_mapping_reader_usage.py \
-		tests/test_display_helper_usage.py \
-		tests/test_ci_workflow_quality_gates.py \
-		tests/test_makefile_quality_targets.py
+	$(PYTHON) -m pytest -q -m architecture
 
 compile:
 	$(PYTHON) -m compileall -q hyperbrowser examples tests

README.md

@@ -249,7 +249,7 @@ make ci
 ```
 
 `make architecture-check` runs fast architecture guard suites
-(shared-helper adoption and quality-gate workflow checks).
+(shared-helper adoption and quality-gate workflow checks) via `pytest -m architecture`.
 
 Contributor workflow details are available in [CONTRIBUTING.md](CONTRIBUTING.md).
 

pyproject.toml

@@ -22,6 +22,9 @@ pytest = "^8.0.0"
 
 [tool.pytest.ini_options]
 testpaths = ["tests"]
+markers = [
+    "architecture: architecture/guardrail quality gate tests",
+]
 
 
 [build-system]

tests/test_ci_workflow_quality_gates.py

@@ -1,5 +1,9 @@
 from pathlib import Path
 
+import pytest
+
+pytestmark = pytest.mark.architecture
+
 
 def test_ci_workflow_includes_architecture_guard_job():
     ci_workflow = Path(".github/workflows/ci.yml").read_text(encoding="utf-8")

tests/test_display_helper_usage.py

@@ -1,7 +1,11 @@
 from pathlib import Path
 
+import pytest
+
 from tests.guardrail_ast_utils import collect_name_call_lines, read_module_ast
 
+pytestmark = pytest.mark.architecture
+
 HYPERBROWSER_ROOT = Path(__file__).resolve().parents[1] / "hyperbrowser"
 ALLOWED_NORMALIZE_DISPLAY_CALL_FILES = {
     Path("display_utils.py"),
@@ -13,6 +17,7 @@
 def _python_files() -> list[Path]:
     return sorted(HYPERBROWSER_ROOT.rglob("*.py"))
 
+
 def test_normalize_display_text_usage_is_centralized():
     violations: list[str] = []
 

tests/test_guardrail_ast_utils.py

@@ -1,11 +1,15 @@
 import ast
 
+import pytest
+
 from tests.guardrail_ast_utils import (
     collect_attribute_call_lines,
     collect_list_keys_call_lines,
     collect_name_call_lines,
 )
 
+pytestmark = pytest.mark.architecture
+
 
 SAMPLE_MODULE = ast.parse(
     """

tests/test_makefile_quality_targets.py

@@ -1,15 +1,21 @@
 from pathlib import Path
 
+import pytest
+
+pytestmark = pytest.mark.architecture
+
 
 def test_makefile_defines_architecture_check_target():
     makefile_text = Path("Makefile").read_text(encoding="utf-8")
 
     assert "architecture-check:" in makefile_text
-    assert "tests/test_manager_model_dump_usage.py" in makefile_text
-    assert "tests/test_ci_workflow_quality_gates.py" in makefile_text
+    assert "-m architecture" in makefile_text
 
 
 def test_makefile_check_target_includes_architecture_checks():
     makefile_text = Path("Makefile").read_text(encoding="utf-8")
 
-    assert "check: lint format-check compile architecture-check test build" in makefile_text
+    assert (
+        "check: lint format-check compile architecture-check test build"
+        in makefile_text
+    )

tests/test_manager_model_dump_usage.py

@@ -1,7 +1,11 @@
 from pathlib import Path
 
+import pytest
+
 from tests.guardrail_ast_utils import collect_attribute_call_lines, read_module_ast
 
+pytestmark = pytest.mark.architecture
+
 MANAGERS_DIR = (
     Path(__file__).resolve().parents[1] / "hyperbrowser" / "client" / "managers"
 )

tests/test_mapping_keys_access_usage.py

@@ -1,7 +1,11 @@
 from pathlib import Path
 
+import pytest
+
 from tests.guardrail_ast_utils import collect_list_keys_call_lines, read_module_ast
 
+pytestmark = pytest.mark.architecture
+
 HYPERBROWSER_ROOT = Path(__file__).resolve().parents[1] / "hyperbrowser"
 ALLOWED_KEYS_LIST_FILES = {
     Path("mapping_utils.py"),
@@ -12,6 +16,7 @@
 def _python_files() -> list[Path]:
     return sorted(HYPERBROWSER_ROOT.rglob("*.py"))
 
+
 def test_mapping_key_iteration_is_centralized():
     violations: list[str] = []