Skip to content

Commit cb88655

Browse files
Add session utils helper usage centralization guard
Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>
1 parent a296b8c commit cb88655

3 files changed

Lines changed: 17 additions & 0 deletions

File tree

CONTRIBUTING.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,7 @@ This runs lint, format checks, compile checks, tests, and package build.
226226
- `tests/test_session_route_constants_usage.py` (session manager route-constant usage enforcement),
227227
- `tests/test_session_upload_helper_usage.py` (session upload-input normalization helper usage enforcement),
228228
- `tests/test_session_upload_metadata_usage.py` (session upload-helper shared operation-metadata prefix usage enforcement),
229+
- `tests/test_session_utils_helper_usage.py` (session parsing helper usage enforcement),
229230
- `tests/test_start_and_wait_default_constants_usage.py` (shared start-and-wait default-constant usage enforcement),
230231
- `tests/test_start_job_context_helper_usage.py` (shared started-job context helper usage enforcement),
231232
- `tests/test_started_job_helper_boundary.py` (centralization boundary enforcement for started-job helper primitives),

tests/test_architecture_marker_usage.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,7 @@
159159
"tests/test_session_route_constants_usage.py",
160160
"tests/test_session_upload_helper_usage.py",
161161
"tests/test_session_upload_metadata_usage.py",
162+
"tests/test_session_utils_helper_usage.py",
162163
"tests/test_start_and_wait_default_constants_usage.py",
163164
"tests/test_start_job_context_helper_usage.py",
164165
"tests/test_started_job_helper_boundary.py",
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
from pathlib import Path
2+
3+
import pytest
4+
5+
pytestmark = pytest.mark.architecture
6+
7+
SESSION_UTILS_MODULE = Path("hyperbrowser/client/managers/session_utils.py")
8+
9+
10+
def test_session_utils_uses_shared_parse_helpers():
11+
module_text = SESSION_UTILS_MODULE.read_text(encoding="utf-8")
12+
13+
assert "parse_response_model(" in module_text
14+
assert "read_plain_list_items(" in module_text
15+
assert "parse_mapping_list_items(" in module_text

0 commit comments

Comments
 (0)