Centralize shared web manager route constants

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

CONTRIBUTING.md

@@ -134,7 +134,8 @@ This runs lint, format checks, compile checks, tests, and package build.
   - `tests/test_tool_mapping_reader_usage.py` (tools mapping-helper usage),
   - `tests/test_type_utils_usage.py` (type `__mro__` boundary centralization in `hyperbrowser/type_utils.py`),
   - `tests/test_web_pagination_internal_reuse.py` (web pagination helper internal reuse of shared job pagination helpers),
-  - `tests/test_web_payload_helper_usage.py` (web manager payload-helper usage enforcement).
+  - `tests/test_web_payload_helper_usage.py` (web manager payload-helper usage enforcement),
+  - `tests/test_web_route_constants_usage.py` (web manager route-constant usage enforcement).
 
 ## Code quality conventions
 

hyperbrowser/client/managers/async_manager/web/batch_fetch.py

@@ -9,6 +9,7 @@
 )
 from ...page_params_utils import build_page_batch_params
 from ...job_status_utils import is_default_terminal_job_status
+from ...web_route_constants import BATCH_FETCH_JOB_ROUTE_PREFIX
 from ...web_payload_utils import build_batch_fetch_start_payload
 from ...web_payload_utils import build_batch_fetch_get_params
 from ...web_pagination_utils import (
@@ -34,6 +35,8 @@
 
 
 class BatchFetchManager:
+    _ROUTE_PREFIX = BATCH_FETCH_JOB_ROUTE_PREFIX
+
     def __init__(self, client):
         self._client = client
 
@@ -43,7 +46,7 @@ async def start(
         payload = build_batch_fetch_start_payload(params)
 
         response = await self._client.transport.post(
-            self._client._build_url("/web/batch-fetch"),
+            self._client._build_url(self._ROUTE_PREFIX),
             data=payload,
         )
         return parse_response_model(
@@ -54,7 +57,7 @@ async def start(
 
     async def get_status(self, job_id: str) -> BatchFetchJobStatusResponse:
         response = await self._client.transport.get(
-            self._client._build_url(f"/web/batch-fetch/{job_id}/status")
+            self._client._build_url(f"{self._ROUTE_PREFIX}/{job_id}/status")
         )
         return parse_response_model(
             response.data,
@@ -67,7 +70,7 @@ async def get(
     ) -> BatchFetchJobResponse:
         query_params = build_batch_fetch_get_params(params)
         response = await self._client.transport.get(
-            self._client._build_url(f"/web/batch-fetch/{job_id}"),
+            self._client._build_url(f"{self._ROUTE_PREFIX}/{job_id}"),
             params=query_params,
         )
         return parse_response_model(

hyperbrowser/client/managers/async_manager/web/crawl.py

@@ -9,6 +9,7 @@
 )
 from ...page_params_utils import build_page_batch_params
 from ...job_status_utils import is_default_terminal_job_status
+from ...web_route_constants import WEB_CRAWL_JOB_ROUTE_PREFIX
 from ...web_payload_utils import build_web_crawl_start_payload
 from ...web_payload_utils import build_web_crawl_get_params
 from ...web_pagination_utils import (
@@ -34,14 +35,16 @@
 
 
 class WebCrawlManager:
+    _ROUTE_PREFIX = WEB_CRAWL_JOB_ROUTE_PREFIX
+
     def __init__(self, client):
         self._client = client
 
     async def start(self, params: StartWebCrawlJobParams) -> StartWebCrawlJobResponse:
         payload = build_web_crawl_start_payload(params)
 
         response = await self._client.transport.post(
-            self._client._build_url("/web/crawl"),
+            self._client._build_url(self._ROUTE_PREFIX),
             data=payload,
         )
         return parse_response_model(
@@ -52,7 +55,7 @@ async def start(self, params: StartWebCrawlJobParams) -> StartWebCrawlJobRespons
 
     async def get_status(self, job_id: str) -> WebCrawlJobStatusResponse:
         response = await self._client.transport.get(
-            self._client._build_url(f"/web/crawl/{job_id}/status")
+            self._client._build_url(f"{self._ROUTE_PREFIX}/{job_id}/status")
         )
         return parse_response_model(
             response.data,
@@ -65,7 +68,7 @@ async def get(
     ) -> WebCrawlJobResponse:
         query_params = build_web_crawl_get_params(params)
         response = await self._client.transport.get(
-            self._client._build_url(f"/web/crawl/{job_id}"),
+            self._client._build_url(f"{self._ROUTE_PREFIX}/{job_id}"),
             params=query_params,
         )
         return parse_response_model(

hyperbrowser/client/managers/sync_manager/web/batch_fetch.py

@@ -9,6 +9,7 @@
 )
 from ...page_params_utils import build_page_batch_params
 from ...job_status_utils import is_default_terminal_job_status
+from ...web_route_constants import BATCH_FETCH_JOB_ROUTE_PREFIX
 from ...web_payload_utils import build_batch_fetch_start_payload
 from ...web_payload_utils import build_batch_fetch_get_params
 from ...web_pagination_utils import (
@@ -34,14 +35,16 @@
 
 
 class BatchFetchManager:
+    _ROUTE_PREFIX = BATCH_FETCH_JOB_ROUTE_PREFIX
+
     def __init__(self, client):
         self._client = client
 
     def start(self, params: StartBatchFetchJobParams) -> StartBatchFetchJobResponse:
         payload = build_batch_fetch_start_payload(params)
 
         response = self._client.transport.post(
-            self._client._build_url("/web/batch-fetch"),
+            self._client._build_url(self._ROUTE_PREFIX),
             data=payload,
         )
         return parse_response_model(
@@ -52,7 +55,7 @@ def start(self, params: StartBatchFetchJobParams) -> StartBatchFetchJobResponse:
 
     def get_status(self, job_id: str) -> BatchFetchJobStatusResponse:
         response = self._client.transport.get(
-            self._client._build_url(f"/web/batch-fetch/{job_id}/status")
+            self._client._build_url(f"{self._ROUTE_PREFIX}/{job_id}/status")
         )
         return parse_response_model(
             response.data,
@@ -65,7 +68,7 @@ def get(
     ) -> BatchFetchJobResponse:
         query_params = build_batch_fetch_get_params(params)
         response = self._client.transport.get(
-            self._client._build_url(f"/web/batch-fetch/{job_id}"),
+            self._client._build_url(f"{self._ROUTE_PREFIX}/{job_id}"),
             params=query_params,
         )
         return parse_response_model(

hyperbrowser/client/managers/sync_manager/web/crawl.py

@@ -9,6 +9,7 @@
 )
 from ...page_params_utils import build_page_batch_params
 from ...job_status_utils import is_default_terminal_job_status
+from ...web_route_constants import WEB_CRAWL_JOB_ROUTE_PREFIX
 from ...web_payload_utils import build_web_crawl_start_payload
 from ...web_payload_utils import build_web_crawl_get_params
 from ...web_pagination_utils import (
@@ -32,14 +33,16 @@
 
 
 class WebCrawlManager:
+    _ROUTE_PREFIX = WEB_CRAWL_JOB_ROUTE_PREFIX
+
     def __init__(self, client):
         self._client = client
 
     def start(self, params: StartWebCrawlJobParams) -> StartWebCrawlJobResponse:
         payload = build_web_crawl_start_payload(params)
 
         response = self._client.transport.post(
-            self._client._build_url("/web/crawl"),
+            self._client._build_url(self._ROUTE_PREFIX),
             data=payload,
         )
         return parse_response_model(
@@ -50,7 +53,7 @@ def start(self, params: StartWebCrawlJobParams) -> StartWebCrawlJobResponse:
 
     def get_status(self, job_id: str) -> WebCrawlJobStatusResponse:
         response = self._client.transport.get(
-            self._client._build_url(f"/web/crawl/{job_id}/status")
+            self._client._build_url(f"{self._ROUTE_PREFIX}/{job_id}/status")
         )
         return parse_response_model(
             response.data,
@@ -63,7 +66,7 @@ def get(
     ) -> WebCrawlJobResponse:
         query_params = build_web_crawl_get_params(params)
         response = self._client.transport.get(
-            self._client._build_url(f"/web/crawl/{job_id}"),
+            self._client._build_url(f"{self._ROUTE_PREFIX}/{job_id}"),
             params=query_params,
         )
         return parse_response_model(

hyperbrowser/client/managers/web_route_constants.py

@@ -0,0 +1,2 @@
+BATCH_FETCH_JOB_ROUTE_PREFIX = "/web/batch-fetch"
+WEB_CRAWL_JOB_ROUTE_PREFIX = "/web/crawl"

tests/test_architecture_marker_usage.py

@@ -65,6 +65,7 @@
     "tests/test_started_job_helper_boundary.py",
     "tests/test_web_pagination_internal_reuse.py",
     "tests/test_web_payload_helper_usage.py",
+    "tests/test_web_route_constants_usage.py",
 )
 
 

tests/test_core_type_helper_usage.py

@@ -48,6 +48,7 @@
     "hyperbrowser/client/managers/polling_defaults.py",
     "hyperbrowser/client/managers/session_upload_utils.py",
     "hyperbrowser/client/managers/session_profile_update_utils.py",
+    "hyperbrowser/client/managers/web_route_constants.py",
     "hyperbrowser/client/managers/web_pagination_utils.py",
     "hyperbrowser/client/managers/web_payload_utils.py",
     "hyperbrowser/client/managers/start_job_utils.py",

tests/test_web_route_constants.py

@@ -0,0 +1,9 @@
+from hyperbrowser.client.managers.web_route_constants import (
+    BATCH_FETCH_JOB_ROUTE_PREFIX,
+    WEB_CRAWL_JOB_ROUTE_PREFIX,
+)
+
+
+def test_web_route_constants_match_expected_api_paths():
+    assert BATCH_FETCH_JOB_ROUTE_PREFIX == "/web/batch-fetch"
+    assert WEB_CRAWL_JOB_ROUTE_PREFIX == "/web/crawl"

tests/test_web_route_constants_usage.py

@@ -0,0 +1,24 @@
+from pathlib import Path
+
+import pytest
+
+pytestmark = pytest.mark.architecture
+
+
+MODULES = (
+    "hyperbrowser/client/managers/sync_manager/web/batch_fetch.py",
+    "hyperbrowser/client/managers/async_manager/web/batch_fetch.py",
+    "hyperbrowser/client/managers/sync_manager/web/crawl.py",
+    "hyperbrowser/client/managers/async_manager/web/crawl.py",
+)
+
+
+def test_web_managers_use_shared_route_constants():
+    for module_path in MODULES:
+        module_text = Path(module_path).read_text(encoding="utf-8")
+        assert "web_route_constants import" in module_text
+        assert "_ROUTE_PREFIX = " in module_text
+        assert '_ROUTE_PREFIX = "/web/' not in module_text
+        assert "_build_url(self._ROUTE_PREFIX)" in module_text
+        assert '_build_url("/web/' not in module_text
+        assert '_build_url(f"/web/' not in module_text