Validate client timeouts are finite

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/async_client.py

@@ -1,10 +1,9 @@
-from numbers import Real
 from typing import Mapping, Optional
 
-from ..exceptions import HyperbrowserError
 from ..config import ClientConfig
 from ..transport.async_transport import AsyncTransport
 from .base import HyperbrowserBase
+from .timeout_utils import validate_timeout_seconds
 from .managers.async_manager.web import WebManager
 from .managers.async_manager.agents import Agents
 from .managers.async_manager.crawl import CrawlManager
@@ -28,11 +27,7 @@ def __init__(
         headers: Optional[Mapping[str, str]] = None,
         timeout: Optional[float] = 30,
     ):
-        if timeout is not None:
-            if isinstance(timeout, bool) or not isinstance(timeout, Real):
-                raise HyperbrowserError("timeout must be a number")
-            if timeout < 0:
-                raise HyperbrowserError("timeout must be non-negative")
+        validate_timeout_seconds(timeout)
         super().__init__(AsyncTransport, config, api_key, base_url, headers)
         self.transport.client.timeout = timeout
         self.sessions = SessionManager(self)

hyperbrowser/client/sync.py

@@ -1,10 +1,9 @@
-from numbers import Real
 from typing import Mapping, Optional
 
-from ..exceptions import HyperbrowserError
 from ..config import ClientConfig
 from ..transport.sync import SyncTransport
 from .base import HyperbrowserBase
+from .timeout_utils import validate_timeout_seconds
 from .managers.sync_manager.web import WebManager
 from .managers.sync_manager.agents import Agents
 from .managers.sync_manager.crawl import CrawlManager
@@ -28,11 +27,7 @@ def __init__(
         headers: Optional[Mapping[str, str]] = None,
         timeout: Optional[float] = 30,
     ):
-        if timeout is not None:
-            if isinstance(timeout, bool) or not isinstance(timeout, Real):
-                raise HyperbrowserError("timeout must be a number")
-            if timeout < 0:
-                raise HyperbrowserError("timeout must be non-negative")
+        validate_timeout_seconds(timeout)
         super().__init__(SyncTransport, config, api_key, base_url, headers)
         self.transport.client.timeout = timeout
         self.sessions = SessionManager(self)

hyperbrowser/client/timeout_utils.py

@@ -0,0 +1,16 @@
+import math
+from numbers import Real
+from typing import Optional
+
+from ..exceptions import HyperbrowserError
+
+
+def validate_timeout_seconds(timeout: Optional[float]) -> None:
+    if timeout is None:
+        return
+    if isinstance(timeout, bool) or not isinstance(timeout, Real):
+        raise HyperbrowserError("timeout must be a number")
+    if not math.isfinite(float(timeout)):
+        raise HyperbrowserError("timeout must be finite")
+    if timeout < 0:
+        raise HyperbrowserError("timeout must be non-negative")

tests/test_client_timeout.py

@@ -1,4 +1,5 @@
 import asyncio
+import math
 
 import pytest
 
@@ -47,3 +48,15 @@ def test_sync_client_rejects_boolean_timeout():
 def test_async_client_rejects_boolean_timeout():
     with pytest.raises(HyperbrowserError, match="timeout must be a number"):
         AsyncHyperbrowser(api_key="test-key", timeout=False)
+
+
+@pytest.mark.parametrize("invalid_timeout", [math.inf, -math.inf, math.nan])
+def test_sync_client_rejects_non_finite_timeout(invalid_timeout: float):
+    with pytest.raises(HyperbrowserError, match="timeout must be finite"):
+        Hyperbrowser(api_key="test-key", timeout=invalid_timeout)
+
+
+@pytest.mark.parametrize("invalid_timeout", [math.inf, -math.inf, math.nan])
+def test_async_client_rejects_non_finite_timeout(invalid_timeout: float):
+    with pytest.raises(HyperbrowserError, match="timeout must be finite"):
+        AsyncHyperbrowser(api_key="test-key", timeout=invalid_timeout)