Wrap tool param-key empty-check length failures

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/tools/__init__.py

@@ -146,14 +146,15 @@ def _to_param_dict(params: Mapping[str, Any]) -> Dict[str, Any]:
                 normalized_key = key.strip()
                 if not isinstance(normalized_key, str):
                     raise TypeError("normalized tool param key must be a string")
+                is_empty_key = len(normalized_key) == 0
             except HyperbrowserError:
                 raise
             except Exception as exc:
                 raise HyperbrowserError(
                     "Failed to normalize tool param key",
                     original_error=exc,
                 ) from exc
-            if not normalized_key:
+            if is_empty_key:
                 raise HyperbrowserError("tool params keys must not be empty")
             try:
                 has_surrounding_whitespace = key != normalized_key

tests/test_tools_mapping_inputs.py

@@ -300,6 +300,46 @@ def strip(self, chars=None):  # type: ignore[override]
     assert isinstance(exc_info.value.original_error, TypeError)
 
 
+@pytest.mark.parametrize("runner", [_run_scrape_tool_sync, _run_scrape_tool_async])
+def test_tool_wrappers_wrap_param_key_empty_check_length_failures(runner):
+    class _BrokenStripKey(str):
+        class _NormalizedKey(str):
+            def __len__(self):
+                raise RuntimeError("tool param key length exploded")
+
+        def strip(self, chars=None):  # type: ignore[override]
+            _ = chars
+            return self._NormalizedKey("url")
+
+    with pytest.raises(
+        HyperbrowserError, match="Failed to normalize tool param key"
+    ) as exc_info:
+        runner({_BrokenStripKey("url"): "https://example.com"})
+
+    assert isinstance(exc_info.value.original_error, RuntimeError)
+
+
+@pytest.mark.parametrize("runner", [_run_scrape_tool_sync, _run_scrape_tool_async])
+def test_tool_wrappers_preserve_hyperbrowser_param_key_empty_check_length_failures(
+    runner,
+):
+    class _BrokenStripKey(str):
+        class _NormalizedKey(str):
+            def __len__(self):
+                raise HyperbrowserError("custom tool param key length failure")
+
+        def strip(self, chars=None):  # type: ignore[override]
+            _ = chars
+            return self._NormalizedKey("url")
+
+    with pytest.raises(
+        HyperbrowserError, match="custom tool param key length failure"
+    ) as exc_info:
+        runner({_BrokenStripKey("url"): "https://example.com"})
+
+    assert exc_info.value.original_error is None
+
+
 @pytest.mark.parametrize("runner", [_run_scrape_tool_sync, _run_scrape_tool_async])
 def test_tool_wrappers_wrap_param_key_character_validation_failures(runner):
     class _BrokenIterKey(str):