Normalize session profile update argument errors to HyperbrowserError

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/async_manager/session.py

@@ -191,26 +191,26 @@ async def update_profile_params(
 
         if isinstance(params, UpdateSessionProfileParams):
             if persist_changes is not None:
-                raise TypeError(
+                raise HyperbrowserError(
                     "Pass either UpdateSessionProfileParams as the second argument or persist_changes=bool, not both."
                 )
             params_obj = params
         elif isinstance(params, bool):
             if persist_changes is not None:
-                raise TypeError(
+                raise HyperbrowserError(
                     "Pass either a boolean as the second argument or persist_changes=bool, not both."
                 )
             self._warn_update_profile_params_boolean_deprecated()
             params_obj = UpdateSessionProfileParams(persist_changes=params)
         elif params is None:
             if persist_changes is None:
-                raise TypeError(
+                raise HyperbrowserError(
                     "update_profile_params() requires either UpdateSessionProfileParams or persist_changes=bool."
                 )
             self._warn_update_profile_params_boolean_deprecated()
             params_obj = UpdateSessionProfileParams(persist_changes=persist_changes)
         else:
-            raise TypeError(
+            raise HyperbrowserError(
                 "update_profile_params() requires either UpdateSessionProfileParams or a boolean persist_changes."
             )
 

hyperbrowser/client/managers/sync_manager/session.py

@@ -183,26 +183,26 @@ def update_profile_params(
 
         if isinstance(params, UpdateSessionProfileParams):
             if persist_changes is not None:
-                raise TypeError(
+                raise HyperbrowserError(
                     "Pass either UpdateSessionProfileParams as the second argument or persist_changes=bool, not both."
                 )
             params_obj = params
         elif isinstance(params, bool):
             if persist_changes is not None:
-                raise TypeError(
+                raise HyperbrowserError(
                     "Pass either a boolean as the second argument or persist_changes=bool, not both."
                 )
             self._warn_update_profile_params_boolean_deprecated()
             params_obj = UpdateSessionProfileParams(persist_changes=params)
         elif params is None:
             if persist_changes is None:
-                raise TypeError(
+                raise HyperbrowserError(
                     "update_profile_params() requires either UpdateSessionProfileParams or persist_changes=bool."
                 )
             self._warn_update_profile_params_boolean_deprecated()
             params_obj = UpdateSessionProfileParams(persist_changes=persist_changes)
         else:
-            raise TypeError(
+            raise HyperbrowserError(
                 "update_profile_params() requires either UpdateSessionProfileParams or a boolean persist_changes."
             )
 

tests/test_session_update_profile_params.py

@@ -9,6 +9,7 @@
 from hyperbrowser.client.managers.sync_manager.session import (
     SessionManager as SyncSessionManager,
 )
+from hyperbrowser.exceptions import HyperbrowserError
 from hyperbrowser.models.session import UpdateSessionProfileParams
 
 
@@ -86,7 +87,7 @@ def test_sync_update_profile_params_bool_deprecation_warning_only_emitted_once()
 def test_sync_update_profile_params_rejects_conflicting_arguments():
     manager = SyncSessionManager(_SyncClient())
 
-    with pytest.raises(TypeError, match="not both"):
+    with pytest.raises(HyperbrowserError, match="not both"):
         manager.update_profile_params(
             "session-1",
             UpdateSessionProfileParams(persist_changes=True),
@@ -127,7 +128,7 @@ def test_async_update_profile_params_rejects_conflicting_arguments():
     manager = AsyncSessionManager(_AsyncClient())
 
     async def run() -> None:
-        with pytest.raises(TypeError, match="not both"):
+        with pytest.raises(HyperbrowserError, match="not both"):
             await manager.update_profile_params(
                 "session-1",
                 UpdateSessionProfileParams(persist_changes=True),
@@ -140,5 +141,15 @@ async def run() -> None:
 def test_sync_update_profile_params_requires_argument_or_keyword():
     manager = SyncSessionManager(_SyncClient())
 
-    with pytest.raises(TypeError, match="requires either"):
+    with pytest.raises(HyperbrowserError, match="requires either"):
         manager.update_profile_params("session-1")
+
+
+def test_async_update_profile_params_requires_argument_or_keyword():
+    manager = AsyncSessionManager(_AsyncClient())
+
+    async def run() -> None:
+        with pytest.raises(HyperbrowserError, match="requires either"):
+            await manager.update_profile_params("session-1")
+
+    asyncio.run(run())